Move GLContext creation from //ui/gl to //ui/gl/init.

Move GLContext creation from //ui/gl to //ui/gl/init.

Move the code that performs GLContext creation to the new target. Remove
the old code and delete the static method from GLContext entirely.

This adds gl_factory_<platform>.cc files for all platforms. These
platform specific files will have GLSurface creation code added next.

Add InitializeGLContext() function to simplify a common pattern that is
repeated frequently. When a new GLContext is created, it's wrapped in a
scoped_refptr and then initialized. If initialization fails nullptr is
returned instead. Encapsulate this logic into a function instead of
repeating it.

There is one code change in GLSurfaceEGL::InitalizeOneOff(). It creates
a GLContext to test if surfaceless contexts are supported. It can no
longer use the deleted method in GLContext. All platforms that hit this
code path will end up creating a GLContextEGL, so just directly
instantiate it.

This change is part of step two from the associated bug.

BUG=611142
Committed: https://crrev.com/872f45f441e8f7ec36b6947d32622918ffe15fae
Cr-Commit-Position: refs/heads/master@{#398350}

[kylechar, 2016-06-02 19:57:57]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-02 19:59:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2037793002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2037793002/1

[commit-bot: I haz the power, 2016-06-02 20:17:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 20:17:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kylechar, 2016-06-03 14:15:30]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-03 14:15:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2037793002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2037793002/20001

[kylechar, 2016-06-03 14:47:00]

Description was changed from

==========
Move GLContext creation from //ui/gl to //ui/gl/init.

Move the code that performs GLContext creation to the new target. Remove
the old code and delete the static method from GLContext entirely.

This adds gl_factory_<platform>.cc files for all platforms. These
platform specific files will have GLSurface creation code added next.

Add InitGLContext() function to simplify a common pattern that is
repeated frequently. When a new GLContext is created, it's wrapped in a
scoped_refptr and then initialized. If initialization fails nullptr is
returned instead. Encapsulate this logic into a single function that can
be reused.

There is one code change in GLSurfaceEGL::InitalizeOneOff(). It creates
a GLContext to test if surfaceless contexts are supported. It can no
longer use the deleted method in GLContext. All platforms that hit this
code path will end up creating a GLContextEGL, so just directly
instantiate it.

This change is part of step two from the associated bug.

BUG=611142
==========

to

==========
Move GLContext creation from //ui/gl to //ui/gl/init.

Move the code that performs GLContext creation to the new target. Remove
the old code and delete the static method from GLContext entirely.

This adds gl_factory_<platform>.cc files for all platforms. These
platform specific files will have GLSurface creation code added next.

Add InitializeGLContext() function to simplify a common pattern that is
repeated frequently. When a new GLContext is created, it's wrapped in a
scoped_refptr and then initialized. If initialization fails nullptr is
returned instead. Encapsulate this logic into a single function that can
be reused.

There is one code change in GLSurfaceEGL::InitalizeOneOff(). It creates
a GLContext to test if surfaceless contexts are supported. It can no
longer use the deleted method in GLContext. All platforms that hit this
code path will end up creating a GLContextEGL, so just directly
instantiate it.

This change is part of step two from the associated bug.

BUG=611142
==========

[commit-bot: I haz the power, 2016-06-03 14:50:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 14:50:59]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[kylechar, 2016-06-03 16:33:39]

Description was changed from

==========
Move GLContext creation from //ui/gl to //ui/gl/init.

Move the code that performs GLContext creation to the new target. Remove
the old code and delete the static method from GLContext entirely.

This adds gl_factory_<platform>.cc files for all platforms. These
platform specific files will have GLSurface creation code added next.

Add InitializeGLContext() function to simplify a common pattern that is
repeated frequently. When a new GLContext is created, it's wrapped in a
scoped_refptr and then initialized. If initialization fails nullptr is
returned instead. Encapsulate this logic into a single function that can
be reused.

There is one code change in GLSurfaceEGL::InitalizeOneOff(). It creates
a GLContext to test if surfaceless contexts are supported. It can no
longer use the deleted method in GLContext. All platforms that hit this
code path will end up creating a GLContextEGL, so just directly
instantiate it.

This change is part of step two from the associated bug.

BUG=611142
==========

to

==========
Move GLContext creation from //ui/gl to //ui/gl/init.

Move the code that performs GLContext creation to the new target. Remove
the old code and delete the static method from GLContext entirely.

This adds gl_factory_<platform>.cc files for all platforms. These
platform specific files will have GLSurface creation code added next.

Add InitializeGLContext() function to simplify a common pattern that is
repeated frequently. When a new GLContext is created, it's wrapped in a
scoped_refptr and then initialized. If initialization fails nullptr is
returned instead. Encapsulate this logic into a function instead of
repeating it.

There is one code change in GLSurfaceEGL::InitalizeOneOff(). It creates
a GLContext to test if surfaceless contexts are supported. It can no
longer use the deleted method in GLContext. All platforms that hit this
code path will end up creating a GLContextEGL, so just directly
instantiate it.

This change is part of step two from the associated bug.

BUG=611142
==========

[kylechar, 2016-06-03 16:34:57]

kylechar@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2016-06-03 20:37:25]

lgtm

https://codereview.chromium.org/2037793002/diff/40001/ui/gl/gl_context.h
File ui/gl/gl_context.h (right):

https://codereview.chromium.org/2037793002/diff/40001/ui/gl/gl_context.h#newc...
ui/gl/gl_context.h:205: GLContext* raw_context,
nit: since your're taking (and returning) a reference, pass a
scoped_refptr<GLContext> and use std::move as appropriate (in the
implementation, in callers).

[kylechar, 2016-06-07 14:43:43]

https://codereview.chromium.org/2037793002/diff/40001/ui/gl/gl_context.h
File ui/gl/gl_context.h (right):

https://codereview.chromium.org/2037793002/diff/40001/ui/gl/gl_context.h#newc...
ui/gl/gl_context.h:205: GLContext* raw_context,
On 2016/06/03 20:37:25, piman OOO back 2016-6-9 wrote:
> nit: since your're taking (and returning) a reference, pass a
> scoped_refptr<GLContext> and use std::move as appropriate (in the
> implementation, in callers).

Done.

[kylechar, 2016-06-07 14:43:51]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-06-07 14:43:52]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2037793002/#ps60001
(title: "Change to scoped_refptr.")

[commit-bot: I haz the power, 2016-06-07 14:44:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2037793002/60001

[commit-bot: I haz the power, 2016-06-07 17:01:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 17:01:26]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kylechar, 2016-06-07 17:25:32]

On 2016/06/07 17:01:26, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Looks flakey. Going to try it again.

[kylechar, 2016-06-07 17:25:38]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2016-06-07 17:26:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2037793002/60001

[commit-bot: I haz the power, 2016-06-07 18:27:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-07 18:29:55]

Description was changed from

==========
Move GLContext creation from //ui/gl to //ui/gl/init.

Move the code that performs GLContext creation to the new target. Remove
the old code and delete the static method from GLContext entirely.

This adds gl_factory_<platform>.cc files for all platforms. These
platform specific files will have GLSurface creation code added next.

Add InitializeGLContext() function to simplify a common pattern that is
repeated frequently. When a new GLContext is created, it's wrapped in a
scoped_refptr and then initialized. If initialization fails nullptr is
returned instead. Encapsulate this logic into a function instead of
repeating it.

There is one code change in GLSurfaceEGL::InitalizeOneOff(). It creates
a GLContext to test if surfaceless contexts are supported. It can no
longer use the deleted method in GLContext. All platforms that hit this
code path will end up creating a GLContextEGL, so just directly
instantiate it.

This change is part of step two from the associated bug.

BUG=611142
==========

to

==========
Move GLContext creation from //ui/gl to //ui/gl/init.

Move the code that performs GLContext creation to the new target. Remove
the old code and delete the static method from GLContext entirely.

This adds gl_factory_<platform>.cc files for all platforms. These
platform specific files will have GLSurface creation code added next.

Add InitializeGLContext() function to simplify a common pattern that is
repeated frequently. When a new GLContext is created, it's wrapped in a
scoped_refptr and then initialized. If initialization fails nullptr is
returned instead. Encapsulate this logic into a function instead of
repeating it.

There is one code change in GLSurfaceEGL::InitalizeOneOff(). It creates
a GLContext to test if surfaceless contexts are supported. It can no
longer use the deleted method in GLContext. All platforms that hit this
code path will end up creating a GLContextEGL, so just directly
instantiate it.

This change is part of step two from the associated bug.

BUG=611142

Committed: https://crrev.com/872f45f441e8f7ec36b6947d32622918ffe15fae
Cr-Commit-Position: refs/heads/master@{#398350}
==========

[commit-bot: I haz the power, 2016-06-07 18:29:56]

Patchset 4 (id:??) landed as
https://crrev.com/872f45f441e8f7ec36b6947d32622918ffe15fae
Cr-Commit-Position: refs/heads/master@{#398350}