PaymentRequest: Rename ShippingAddress to PaymentAddress.

PaymentRequest: Rename ShippingAddress to PaymentAddress.

Rename the address type since it will likely be used for other purpose.

Related spec links:
  [1] https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentaddress-interface
  [2] https://github.com/w3c/browser-payment-api/commit/576550c4de9f47feb889f8f7e587b2853e2da668

BUG=none

Committed: https://crrev.com/60e81e7f305496104a8a239e668fd60839318d3a
Cr-Commit-Position: refs/heads/master@{#397670}

[zino, 2016-05-30 14:32:51]

Description was changed from

==========
Rename ShippingAddress -> PaymentAddress

BUG=
==========

to

==========
PaymentRequest: Rename ShippingAddress to PaymentAddress.

Rename the address type since it will likely be used for other purpose.

Related spec links:
  [1]
https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentad...
  [2]
https://github.com/w3c/browser-payment-api/commit/576550c4de9f47feb889f8f7e58...

BUG=none
==========

[zino, 2016-05-30 14:33:03]

Patchset #1 (id:1) has been deleted

[zino, 2016-05-30 14:33:13]

Patchset #1 (id:20001) has been deleted

[zino, 2016-05-30 14:33:22]

Patchset #1 (id:40001) has been deleted

[zino, 2016-05-30 17:14:01]

jinho.bang@samsung.com changed reviewers:
+ rouslan@chromium.org

[zino, 2016-05-30 17:14:14]

PTAL

[please use gerrit instead, 2016-05-31 01:44:43]

Please add a test to payment-request-interface.html that checks
window.PaymentAddress is defined.

https://codereview.chromium.org/2020913002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentAddress.idl (right):

https://codereview.chromium.org/2020913002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentAddress.idl:5: //
https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#shippinga...
Update this link.

https://codereview.chromium.org/2020913002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentsValidators.h (right):

https://codereview.chromium.org/2020913002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentsValidators.h:34: // Returns
true if the shipping address is valid:
s/shipping/payment/

[zino, 2016-05-31 02:58:31]

Thank you for review.

I added a layout test.
BTW, although we already have webexposed tests to check whether interfaces or
attributes are defined and exposed, do we need it?

Please let me know~

Thank you!

https://codereview.chromium.org/2020913002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentAddress.idl (right):

https://codereview.chromium.org/2020913002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentAddress.idl:5: //
https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#shippinga...
On 2016/05/31 01:44:43, Rouslan (ツ) wrote:
> Update this link.

Done.

https://codereview.chromium.org/2020913002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentsValidators.h (right):

https://codereview.chromium.org/2020913002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentsValidators.h:34: // Returns
true if the shipping address is valid:
On 2016/05/31 01:44:43, Rouslan (ツ) wrote:
> s/shipping/payment/

Done.

[please use gerrit instead, 2016-05-31 15:22:27]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org, palmer@chromium.org

[please use gerrit instead, 2016-05-31 15:22:28]

lgtm

Good point about web-exposed tests. You can remove the new layout test. Sorry
for the extra work.

+palmer@ for payment_request.mojom

+dfalcantara@ for Java.

[gone, 2016-05-31 18:34:30]

java bits lgtm

https://chromiumcodereview.appspot.com/2020913002/diff/100001/chrome/android/...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java
(right):

https://chromiumcodereview.appspot.com/2020913002/diff/100001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java:55:
* Returns the shipping address for mojo.
Does this comment need to be updated?

[please use gerrit instead, 2016-05-31 19:51:22]

On 2016/05/31 18:34:30, dfalcantara wrote:
>
https://chromiumcodereview.appspot.com/2020913002/diff/100001/chrome/android/...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java
> (right):
> 
>
https://chromiumcodereview.appspot.com/2020913002/diff/100001/chrome/android/...
>
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java:55:
> * Returns the shipping address for mojo.
> Does this comment need to be updated?

IMHO it's OK as-is.

[zino, 2016-06-01 17:51:30]

palmer@, Gentle ping.

[please use gerrit instead, 2016-06-02 19:46:28]

rouslan@chromium.org changed reviewers:
+ tsepez@chromium.org
- palmer@chromium.org

[please use gerrit instead, 2016-06-02 19:46:29]

+tsepez@, ptal payment_request.mojom.

-palmer@, who is ooo.

[Tom Sepez, 2016-06-02 20:10:26]

lgtm

[zino, 2016-06-02 23:36:55]

The CQ bit was checked by jinho.bang@samsung.com

[zino, 2016-06-02 23:36:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
rouslan@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2020913002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2016-06-02 23:38:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2020913002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2020913002/120001

[zino, 2016-06-03 00:03:03]

The CQ bit was unchecked by jinho.bang@samsung.com

[zino, 2016-06-03 09:00:34]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2016-06-03 09:00:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2020913002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2020913002/120001

[commit-bot: I haz the power, 2016-06-03 09:05:07]

Description was changed from

==========
PaymentRequest: Rename ShippingAddress to PaymentAddress.

Rename the address type since it will likely be used for other purpose.

Related spec links:
  [1]
https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentad...
  [2]
https://github.com/w3c/browser-payment-api/commit/576550c4de9f47feb889f8f7e58...

BUG=none
==========

to

==========
PaymentRequest: Rename ShippingAddress to PaymentAddress.

Rename the address type since it will likely be used for other purpose.

Related spec links:
  [1]
https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentad...
  [2]
https://github.com/w3c/browser-payment-api/commit/576550c4de9f47feb889f8f7e58...

BUG=none
==========

[commit-bot: I haz the power, 2016-06-03 09:05:09]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2016-06-03 09:07:14]

Description was changed from

==========
PaymentRequest: Rename ShippingAddress to PaymentAddress.

Rename the address type since it will likely be used for other purpose.

Related spec links:
  [1]
https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentad...
  [2]
https://github.com/w3c/browser-payment-api/commit/576550c4de9f47feb889f8f7e58...

BUG=none
==========

to

==========
PaymentRequest: Rename ShippingAddress to PaymentAddress.

Rename the address type since it will likely be used for other purpose.

Related spec links:
  [1]
https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentad...
  [2]
https://github.com/w3c/browser-payment-api/commit/576550c4de9f47feb889f8f7e58...

BUG=none

Committed: https://crrev.com/60e81e7f305496104a8a239e668fd60839318d3a
Cr-Commit-Position: refs/heads/master@{#397670}
==========

[commit-bot: I haz the power, 2016-06-03 09:07:16]

Patchset 4 (id:??) landed as
https://crrev.com/60e81e7f305496104a8a239e668fd60839318d3a
Cr-Commit-Position: refs/heads/master@{#397670}