Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2018603003: Remove VisualBench and its Android implementation. (Closed)

Created:
4 years, 7 months ago by djsollen
Modified:
4 years, 6 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5081 lines) Patch
M gyp/everything.gyp View 1 chunk +0 lines, -7 lines 0 comments Download
D gyp/kilobench.gyp View 1 chunk +0 lines, -41 lines 0 comments Download
M gyp/most.gyp View 3 chunks +0 lines, -11 lines 0 comments Download
D gyp/visualbench.gyp View 1 chunk +0 lines, -73 lines 0 comments Download
M platform_tools/android/apps/settings.gradle View 1 chunk +0 lines, -2 lines 0 comments Download
D platform_tools/android/apps/visualbench/build.gradle View 1 chunk +0 lines, -30 lines 0 comments Download
D platform_tools/android/apps/visualbench/src/main/AndroidManifest.xml View 1 chunk +0 lines, -29 lines 0 comments Download
D platform_tools/android/apps/visualbench/src/main/java/com/skia/VisualBenchActivity.java View 1 chunk +0 lines, -46 lines 0 comments Download
D platform_tools/android/apps/visualbench/src/main/java/com/skia/VisualBenchTestActivity.java View 1 chunk +0 lines, -62 lines 0 comments Download
D platform_tools/android/apps/visualbench/src/main/jni/SkOSWindow_AndroidNative.cpp View 1 chunk +0 lines, -200 lines 0 comments Download
D platform_tools/android/apps/visualbench/src/main/jni/main.cpp View 1 chunk +0 lines, -134 lines 0 comments Download
D platform_tools/android/apps/visualbenchsdl/build.gradle View 1 chunk +0 lines, -30 lines 0 comments Download
D platform_tools/android/apps/visualbenchsdl/src/main/AndroidManifest.xml View 1 chunk +0 lines, -29 lines 0 comments Download
D platform_tools/android/apps/visualbenchsdl/src/main/java/com/skia/VisualBenchActivity.java View 1 chunk +0 lines, -22 lines 0 comments Download
D platform_tools/android/apps/visualbenchsdl/src/main/java/com/skia/VisualBenchTestActivity.java View 1 chunk +0 lines, -62 lines 0 comments Download
D platform_tools/android/apps/visualbenchsdl/src/main/java/org/libsdl/app/SDLActivity.java View 1 chunk +0 lines, -1684 lines 0 comments Download
M platform_tools/android/bin/android_install_app View 1 chunk +1 line, -1 line 0 comments Download
M platform_tools/android/bin/android_launch_app View 1 chunk +2 lines, -2 lines 0 comments Download
D platform_tools/android/bin/android_run_app.go View 1 chunk +0 lines, -248 lines 0 comments Download
M platform_tools/android/gyp/dependencies.gypi View 1 chunk +0 lines, -34 lines 0 comments Download
M platform_tools/android/gyp/skia_android.gypi View 1 chunk +0 lines, -163 lines 0 comments Download
D tools/VisualBench/TimingStateMachine.h View 1 chunk +0 lines, -71 lines 0 comments Download
D tools/VisualBench/TimingStateMachine.cpp View 1 chunk +0 lines, -87 lines 0 comments Download
D tools/VisualBench/VisualBench.h View 1 chunk +0 lines, -65 lines 0 comments Download
D tools/VisualBench/VisualBench.cpp View 1 chunk +0 lines, -194 lines 0 comments Download
D tools/VisualBench/VisualBenchmarkStream.h View 1 chunk +0 lines, -43 lines 0 comments Download
D tools/VisualBench/VisualBenchmarkStream.cpp View 1 chunk +0 lines, -188 lines 0 comments Download
D tools/VisualBench/VisualDebugModule.h View 1 chunk +0 lines, -43 lines 0 comments Download
D tools/VisualBench/VisualDebugModule.cpp View 1 chunk +0 lines, -74 lines 0 comments Download
D tools/VisualBench/VisualFlags.h View 1 chunk +0 lines, -19 lines 0 comments Download
D tools/VisualBench/VisualFlags.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
D tools/VisualBench/VisualInteractiveModule.h View 1 chunk +0 lines, -38 lines 0 comments Download
D tools/VisualBench/VisualInteractiveModule.cpp View 1 chunk +0 lines, -83 lines 0 comments Download
D tools/VisualBench/VisualLightweightBenchModule.h View 1 chunk +0 lines, -46 lines 0 comments Download
D tools/VisualBench/VisualLightweightBenchModule.cpp View 1 chunk +0 lines, -152 lines 0 comments Download
D tools/VisualBench/VisualModule.h View 1 chunk +0 lines, -34 lines 0 comments Download
D tools/VisualBench/VisualSKPBench.h View 1 chunk +0 lines, -39 lines 0 comments Download
D tools/VisualBench/VisualSKPBench.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
D tools/VisualBench/VisualStreamTimingModule.h View 1 chunk +0 lines, -54 lines 0 comments Download
D tools/VisualBench/VisualStreamTimingModule.cpp View 1 chunk +0 lines, -79 lines 0 comments Download
D tools/VisualBench/WrappedBenchmark.h View 1 chunk +0 lines, -134 lines 0 comments Download
D tools/kilobench/kilobench.cpp View 1 chunk +0 lines, -657 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
djsollen
4 years, 7 months ago (2016-05-26 18:56:10 UTC) #3
bsalomon
lgtm
4 years, 7 months ago (2016-05-26 19:16:10 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018603003/1
4 years, 7 months ago (2016-05-26 19:29:44 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-26 19:58:18 UTC) #8
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-26 19:58:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018603003/1
4 years, 6 months ago (2016-05-27 12:38:26 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 12:39:33 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/41457927364d23ed363bc3ba25025f8a36f1b8d4

Powered by Google App Engine
This is Rietveld 408576698