Disallow local/remote checks on subclasses of Frame, FrameOwner and DOMWindow.

Disallow local/remote checks on subclasses of Frame, FrameOwner and DOMWindow.

If the type is already one of the derived types, it's unnecessary to check if
the object is local or remote. For example, calling LocalFrame::isLocalFrame()
is tautological and will always be true.

BUG=none

Committed: https://crrev.com/aae89d529f4f9b798a53460a403e1fc7c2624ba4
Cr-Commit-Position: refs/heads/master@{#396311}

[dcheng, 2016-05-26 20:25:55]

dcheng@chromium.org changed reviewers:
+ esprehn@chromium.org

[dcheng, 2016-05-26 20:25:56]

Yak shave.

[esprehn, 2016-05-26 20:36:45]

Can we go pure virtual instead and do the actual returns in the classes? I'm not
a big fan of the using statement since you don't know what the superclass
returns (I guess it's not too much of a mystery here)

https://codereview.chromium.org/2015003002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/LocalDOMWindow.h (right):

https://codereview.chromium.org/2015003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/LocalDOMWindow.h:216: using
DOMWindow::isRemoteDOMWindow;
can we just write return false here?

https://codereview.chromium.org/2015003002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/LocalFrame.h (right):

https://codereview.chromium.org/2015003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/LocalFrame.h:194: using
Frame::isRemoteFrame;
ditto?

[dcheng, 2016-05-26 20:45:32]

https://codereview.chromium.org/2015003002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/LocalDOMWindow.h (right):

https://codereview.chromium.org/2015003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/LocalDOMWindow.h:216: using
DOMWindow::isRemoteDOMWindow;
On 2016/05/26 at 20:36:45, esprehn wrote:
> can we just write return false here?

Done.

https://codereview.chromium.org/2015003002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/LocalFrame.h (right):

https://codereview.chromium.org/2015003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/LocalFrame.h:194: using
Frame::isRemoteFrame;
On 2016/05/26 at 20:36:45, esprehn wrote:
> ditto?

Done.

[esprehn, 2016-05-26 20:49:36]

lgtm

[dcheng, 2016-05-26 20:51:28]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-05-26 20:52:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2015003002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2015003002/20001

[commit-bot: I haz the power, 2016-05-26 21:00:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-26 21:00:50]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[haraken, 2016-05-26 21:07:41]

LGTM

[dcheng, 2016-05-26 21:42:31]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-05-26 21:43:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2015003002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2015003002/20001

[commit-bot: I haz the power, 2016-05-26 23:22:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-26 23:23:56]

Description was changed from

==========
Disallow local/remote checks on subclasses of Frame, FrameOwner and DOMWindow.

If the type is already one of the derived types, it's unnecessary to check if
the object is local or remote. For example, calling LocalFrame::isLocalFrame()
is tautological and will always be true.

BUG=none
==========

to

==========
Disallow local/remote checks on subclasses of Frame, FrameOwner and DOMWindow.

If the type is already one of the derived types, it's unnecessary to check if
the object is local or remote. For example, calling LocalFrame::isLocalFrame()
is tautological and will always be true.

BUG=none

Committed: https://crrev.com/aae89d529f4f9b798a53460a403e1fc7c2624ba4
Cr-Commit-Position: refs/heads/master@{#396311}
==========

[commit-bot: I haz the power, 2016-05-26 23:23:57]

Patchset 2 (id:??) landed as
https://crrev.com/aae89d529f4f9b798a53460a403e1fc7c2624ba4
Cr-Commit-Position: refs/heads/master@{#396311}