Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: third_party/WebKit/Source/core/frame/Frame.h

Issue 2015003002: Disallow local/remote checks on subclasses of Frame, FrameOwner and DOMWindow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pure virtual Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999-2001 Lars Knoll <knoll@kde.org> 3 * 1999-2001 Lars Knoll <knoll@kde.org>
4 * 1999-2001 Antti Koivisto <koivisto@kde.org> 4 * 1999-2001 Antti Koivisto <koivisto@kde.org>
5 * 2000-2001 Simon Hausmann <hausmann@kde.org> 5 * 2000-2001 Simon Hausmann <hausmann@kde.org>
6 * 2000-2001 Dirk Mueller <mueller@kde.org> 6 * 2000-2001 Dirk Mueller <mueller@kde.org>
7 * 2000 Stefan Schimanski <1Stein@gmx.de> 7 * 2000 Stefan Schimanski <1Stein@gmx.de>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
9 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 10 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 61
62 // Frame is the base class of LocalFrame and RemoteFrame and should only contain 62 // Frame is the base class of LocalFrame and RemoteFrame and should only contain
63 // functionality shared between both. In particular, any method related to 63 // functionality shared between both. In particular, any method related to
64 // input, layout, or painting probably belongs on LocalFrame. 64 // input, layout, or painting probably belongs on LocalFrame.
65 class CORE_EXPORT Frame : public GarbageCollectedFinalized<Frame> { 65 class CORE_EXPORT Frame : public GarbageCollectedFinalized<Frame> {
66 public: 66 public:
67 virtual ~Frame(); 67 virtual ~Frame();
68 68
69 DECLARE_VIRTUAL_TRACE(); 69 DECLARE_VIRTUAL_TRACE();
70 70
71 virtual bool isLocalFrame() const { return false; } 71 virtual bool isLocalFrame() const = 0;
72 virtual bool isRemoteFrame() const { return false; } 72 virtual bool isRemoteFrame() const = 0;
73 73
74 virtual DOMWindow* domWindow() const = 0; 74 virtual DOMWindow* domWindow() const = 0;
75 virtual WindowProxy* windowProxy(DOMWrapperWorld&) = 0; 75 virtual WindowProxy* windowProxy(DOMWrapperWorld&) = 0;
76 76
77 virtual void navigate(Document& originDocument, const KURL&, bool replaceCur rentItem, UserGestureStatus) = 0; 77 virtual void navigate(Document& originDocument, const KURL&, bool replaceCur rentItem, UserGestureStatus) = 0;
78 // This version of Frame::navigate assumes the resulting navigation is not 78 // This version of Frame::navigate assumes the resulting navigation is not
79 // to be started on a timer. Use the method above in such cases. 79 // to be started on a timer. Use the method above in such cases.
80 virtual void navigate(const FrameLoadRequest&) = 0; 80 virtual void navigate(const FrameLoadRequest&) = 0;
81 virtual void reload(FrameLoadType, ClientRedirectPolicy) = 0; 81 virtual void reload(FrameLoadType, ClientRedirectPolicy) = 0;
82 82
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 { 165 {
166 return m_treeNode; 166 return m_treeNode;
167 } 167 }
168 168
169 // Allow equality comparisons of Frames by reference or pointer, interchangeably . 169 // Allow equality comparisons of Frames by reference or pointer, interchangeably .
170 DEFINE_COMPARISON_OPERATORS_WITH_REFERENCES_REFCOUNTED(Frame) 170 DEFINE_COMPARISON_OPERATORS_WITH_REFERENCES_REFCOUNTED(Frame)
171 171
172 } // namespace blink 172 } // namespace blink
173 173
174 #endif // Frame_h 174 #endif // Frame_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/DOMWindow.h ('k') | third_party/WebKit/Source/core/frame/FrameOwner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698