third_party/WebKit/Source/web/RemoteFrameOwner.h - Issue 2015003002: Disallow local/remote checks on subclasses of Frame, FrameOwner and DOMWindow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/RemoteFrameOwner.h

Issue 2015003002: Disallow local/remote checks on subclasses of Frame, FrameOwner and DOMWindow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pure virtual Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/notifications/NotificationPermissionClient.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/RemoteFrameOwner.h

diff --git a/third_party/WebKit/Source/web/RemoteFrameOwner.h b/third_party/WebKit/Source/web/RemoteFrameOwner.h

index 0ed31e0a7131c244b7d0a063aad5459c1ba10ea3..1c62850681d818f70af9a16b90afbf37552c8b72 100644

--- a/third_party/WebKit/Source/web/RemoteFrameOwner.h

+++ b/third_party/WebKit/Source/web/RemoteFrameOwner.h

@@ -25,8 +25,6 @@ public:

}

// FrameOwner overrides:

- bool isLocal() const override { return false; }

- bool isRemote() const override { return true; }

void setContentFrame(Frame&) override;

void clearContentFrame() override;

SandboxFlags getSandboxFlags() const override { return m_sandboxFlags; }

@@ -49,6 +47,11 @@ public:

private:

RemoteFrameOwner(SandboxFlags, const WebFrameOwnerProperties&);

+ // Intentionally private to prevent redundant checks when the type is

+ // already HTMLFrameOwnerElement.

+ bool isLocal() const override { return false; }

+ bool isRemote() const override { return true; }

Member<Frame> m_frame;

SandboxFlags m_sandboxFlags;

ScrollbarMode m_scrolling;