third_party/WebKit/Source/core/frame/Frame.h - Issue 2015003002: Disallow local/remote checks on subclasses of Frame, FrameOwner and DOMWindow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/Frame.h

Issue 2015003002: Disallow local/remote checks on subclasses of Frame, FrameOwner and DOMWindow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pure virtual Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/frame/Frame.h

diff --git a/third_party/WebKit/Source/core/frame/Frame.h b/third_party/WebKit/Source/core/frame/Frame.h

index 3a93578cf6ad3f63b7179c3ea75bbc86786bc899..423e8824724299e26da638564f437a9c5d755cea 100644

--- a/third_party/WebKit/Source/core/frame/Frame.h

+++ b/third_party/WebKit/Source/core/frame/Frame.h

@@ -68,8 +68,8 @@ public:

DECLARE_VIRTUAL_TRACE();

- virtual bool isLocalFrame() const { return false; }

- virtual bool isRemoteFrame() const { return false; }

+ virtual bool isLocalFrame() const = 0;

+ virtual bool isRemoteFrame() const = 0;

virtual DOMWindow* domWindow() const = 0;

virtual WindowProxy* windowProxy(DOMWrapperWorld&) = 0;

« no previous file with comments | « third_party/WebKit/Source/core/frame/DOMWindow.h ('k') | third_party/WebKit/Source/core/frame/FrameOwner.h » ('j') | no next file with comments »