Disallow local/remote checks on subclasses of Frame, FrameOwner and DOMWindow.

third_party/WebKit/Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 1710 matching lines @@
 }
 
 void WebViewImpl::enablePopupMouseWheelEventListener()
 {
     // TODO(kenrb): Popup coordination for out-of-process iframes needs to be
     // added. Because of the early return here a select element
     // popup can remain visible even when the element underneath it is
     // scrolled to a new position. This is part of a larger set of issues with
     // popups.
     // See https://crbug.com/566130
-    if (!mainFrameImpl() || !mainFrameImpl()->frame()->isLocalFrame())
+    if (!mainFrameImpl())
         return;
     DCHECK(!m_popupMouseWheelEventListener);
     Document* document = mainFrameImpl()->frame()->document();
     DCHECK(document);
     // We register an empty event listener, EmptyEventListener, so that mouse
     // wheel events get sent to the WebView.
     m_popupMouseWheelEventListener = EmptyEventListener::create();
     document->addEventListener(EventTypeNames::mousewheel, m_popupMouseWheelEventListener, false);
 }
 
 void WebViewImpl::disablePopupMouseWheelEventListener()
 {
     // TODO(kenrb): Concerns the same as in enablePopupMouseWheelEventListener.
     // See https://crbug.com/566130
-    if (!mainFrameImpl() || !mainFrameImpl()->frame()->isLocalFrame())
+    if (!mainFrameImpl())
         return;
     DCHECK(m_popupMouseWheelEventListener);
     Document* document = mainFrameImpl()->frame()->document();
     DCHECK(document);
     // Document may have already removed the event listener, for instance, due
     // to a navigation, but remove it anyway.
     document->removeEventListener(EventTypeNames::mousewheel, m_popupMouseWheelEventListener.release(), false);
 }
 
 LocalDOMWindow* WebViewImpl::pagePopupWindow() const
@@ skipping 111 matching lines @@
 
 TopControls& WebViewImpl::topControls()
 {
     return page()->frameHost().topControls();
 }
 
 void WebViewImpl::resizeViewWhileAnchored(
     FrameView* view, float topControlsHeight, bool topControlsShrinkLayout)
 {
     DCHECK(mainFrameImpl());
-    DCHECK(mainFrameImpl()->frame()->isLocalFrame());
 
     topControls().setHeight(topControlsHeight, topControlsShrinkLayout);
 
     {
         // Avoids unnecessary invalidations while various bits of state in TextAutosizer are updated.
         TextAutosizer::DeferUpdatePageInfo deferUpdatePageInfo(page());
         performResize();
     }
 
     m_fullscreenController->updateSize();
@@ skipping 948 matching lines @@
 }
 
 void WebViewImpl::didChangeWindowResizerRect()
 {
     if (mainFrameImpl()->frameView())
         mainFrameImpl()->frameView()->windowResizerRectChanged();
 }
 
 void WebViewImpl::reportFixedRasterScaleUseCounters(bool hasBlurryContent, bool hasPotentialPerformanceRegression)
 {
-    if (!mainFrameImpl() || !mainFrameImpl()->frame()->isLocalFrame())
+    if (!mainFrameImpl())
         return;
     Document* document = mainFrameImpl()->frame()->document();
     if (hasBlurryContent)
         UseCounter::count(document, UseCounter::FixedRasterScaleBlurryContent);
     if (hasPotentialPerformanceRegression)
         UseCounter::count(document, UseCounter::FixedRasterScalePotentialPerformanceRegression);
 }
 
 // WebView --------------------------------------------------------------------
 
@@ skipping 1739 matching lines @@
 {
     // TODO(oshima): Investigate if this should return the ScreenInfo's scale factor rather than
     // page's scale factor, which can be 1 in use-zoom-for-dsf mode.
     if (!page())
         return 1;
 
     return page()->deviceScaleFactor();
 }
 
 } // namespace blink