Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

Issue 2015003002: Disallow local/remote checks on subclasses of Frame, FrameOwner and DOMWindow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pure virtual Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 STACK_ALLOCATED(); 67 STACK_ALLOCATED();
68 public: 68 public:
69 UpdateSuspendScope(); 69 UpdateSuspendScope();
70 ~UpdateSuspendScope(); 70 ~UpdateSuspendScope();
71 71
72 private: 72 private:
73 void performDeferredWidgetTreeOperations(); 73 void performDeferredWidgetTreeOperations();
74 }; 74 };
75 75
76 // FrameOwner overrides: 76 // FrameOwner overrides:
77 bool isLocal() const override { return true; }
78 bool isRemote() const override { return false; }
79 void setContentFrame(Frame&) override; 77 void setContentFrame(Frame&) override;
80 void clearContentFrame() override; 78 void clearContentFrame() override;
81 void dispatchLoad() override; 79 void dispatchLoad() override;
82 SandboxFlags getSandboxFlags() const override { return m_sandboxFlags; } 80 SandboxFlags getSandboxFlags() const override { return m_sandboxFlags; }
83 void renderFallbackContent() override { } 81 void renderFallbackContent() override { }
84 ScrollbarMode scrollingMode() const override { return ScrollbarAuto; } 82 ScrollbarMode scrollingMode() const override { return ScrollbarAuto; }
85 int marginWidth() const override { return -1; } 83 int marginWidth() const override { return -1; }
86 int marginHeight() const override { return -1; } 84 int marginHeight() const override { return -1; }
87 bool allowFullscreen() const override { return false; } 85 bool allowFullscreen() const override { return false; }
88 86
89 DECLARE_VIRTUAL_TRACE(); 87 DECLARE_VIRTUAL_TRACE();
90 88
91 protected: 89 protected:
92 HTMLFrameOwnerElement(const QualifiedName& tagName, Document&); 90 HTMLFrameOwnerElement(const QualifiedName& tagName, Document&);
93 void setSandboxFlags(SandboxFlags); 91 void setSandboxFlags(SandboxFlags);
94 92
95 bool loadOrRedirectSubframe(const KURL&, const AtomicString& frameName, bool replaceCurrentItem); 93 bool loadOrRedirectSubframe(const KURL&, const AtomicString& frameName, bool replaceCurrentItem);
96 94
97 private: 95 private:
96 // Intentionally private to prevent redundant checks when the type is
97 // already HTMLFrameOwnerElement.
98 bool isLocal() const override { return true; }
99 bool isRemote() const override { return false; }
100
98 bool isKeyboardFocusable() const override; 101 bool isKeyboardFocusable() const override;
99 bool isFrameOwnerElement() const final { return true; } 102 bool isFrameOwnerElement() const final { return true; }
100 103
101 virtual ReferrerPolicy referrerPolicyAttribute() { return ReferrerPolicyDefa ult; } 104 virtual ReferrerPolicy referrerPolicyAttribute() { return ReferrerPolicyDefa ult; }
102 105
103 Member<Frame> m_contentFrame; 106 Member<Frame> m_contentFrame;
104 Member<Widget> m_widget; 107 Member<Widget> m_widget;
105 SandboxFlags m_sandboxFlags; 108 SandboxFlags m_sandboxFlags;
106 }; 109 };
107 110
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 CORE_EXPORT static HeapHashCountedSet<Member<Node>>& disabledSubtreeRoots(); 143 CORE_EXPORT static HeapHashCountedSet<Member<Node>>& disabledSubtreeRoots();
141 144
142 Member<Node> m_root; 145 Member<Node> m_root;
143 }; 146 };
144 147
145 DEFINE_TYPE_CASTS(HTMLFrameOwnerElement, FrameOwner, owner, owner->isLocal(), ow ner.isLocal()); 148 DEFINE_TYPE_CASTS(HTMLFrameOwnerElement, FrameOwner, owner, owner->isLocal(), ow ner.isLocal());
146 149
147 } // namespace blink 150 } // namespace blink
148 151
149 #endif // HTMLFrameOwnerElement_h 152 #endif // HTMLFrameOwnerElement_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698