third_party/WebKit/Source/core/frame/DOMWindow.h - Issue 2015003002: Disallow local/remote checks on subclasses of Frame, FrameOwner and DOMWindow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindow.h

Issue 2015003002: Disallow local/remote checks on subclasses of Frame, FrameOwner and DOMWindow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pure virtual Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/frame/DOMWindow.h

diff --git a/third_party/WebKit/Source/core/frame/DOMWindow.h b/third_party/WebKit/Source/core/frame/DOMWindow.h

index 2c4206aa9f4805beb00852075202bb3e776a6a71..251fe2fac8169a5b7fa79d59b187a28cc8003756 100644

--- a/third_party/WebKit/Source/core/frame/DOMWindow.h

+++ b/third_party/WebKit/Source/core/frame/DOMWindow.h

@@ -50,8 +50,8 @@ public:

// GarbageCollectedFinalized overrides:

DECLARE_VIRTUAL_TRACE();

- virtual bool isLocalDOMWindow() const { return false; }

- virtual bool isRemoteDOMWindow() const { return false; }

+ virtual bool isLocalDOMWindow() const = 0;

+ virtual bool isRemoteDOMWindow() const = 0;

virtual Frame* frame() const = 0;

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/Frame.h » ('j') | no next file with comments »