Converts overview to use common ash types

Converts overview to use common ash types

There are a couple of remaining dependencies on the non-ash types. I
plan on removing them next.

BUG=581868
TEST=covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/6624a7af7520226b2513a689055c0425f66d60fc
Cr-Commit-Position: refs/heads/master@{#396523}

[sky, 2016-05-26 21:04:58]

You'll notice a slightly different approach with parts of this patch. In
particular I left a factory implementation in ash/wm/overview (rather than
moving to ash/wm/common) and have files named _aura in said directory. This is
the pattern I'm thinking we use going forward.

I think I'm going to nuke ash/wm/common/wm_user_metrics_action.h entirely. But
will do that separately.

[James Cook, 2016-05-27 00:02:52]

Just a pile of nits

https://codereview.chromium.org/2012343002/diff/20001/ash/metrics/user_metric...
File ash/metrics/user_metrics_recorder.h (left):

https://codereview.chromium.org/2012343002/diff/20001/ash/metrics/user_metric...
ash/metrics/user_metrics_recorder.h:131: UMA_WINDOW_OVERVIEW,
FYI, I asked kuscher@ if we need to maintain these metrics at all. Unfortunately
we do (apparently overview mode is being tweaked soon), but there may be other
classes of metrics we can just remove. I'll follow up with him.

https://codereview.chromium.org/2012343002/diff/20001/ash/shell_window_ids.h
File ash/shell_window_ids.h (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/shell_window_ids.h#...
ash/shell_window_ids.h:187: "overlay between settings-bubble and phanton");
nit: phanton -> phantom

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/aura/wm_globals_...
File ash/wm/aura/wm_globals_aura.cc (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/aura/wm_globals_...
ash/wm/aura/wm_globals_aura.cc:69:
ash::Shell::GetInstance()->mru_window_tracker()->BuildMruWindowList());
nit: no need for ash:: here or below

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/aura/wm_globals_...
File ash/wm/aura/wm_globals_aura.h (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/aura/wm_globals_...
ash/wm/aura/wm_globals_aura.h:35: WmWindow* GetPrimaryRootWindow() override;
Heh, I could have used this method in the CL I just sent you. :-)

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/aura/wm_window_a...
File ash/wm/aura/wm_window_aura.cc (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/aura/wm_window_a...
ash/wm/aura/wm_window_aura.cc:489:
views::Widget::GetWidgetForNativeView(window_)->Close();
This seems a little dangerous to me, since not every aura::Window is going to be
registered with a widget. Maybe the method should be called CloseWidget()? Or
DCHECK? Both?

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/common/wm_activa...
File ash/wm/common/wm_activation_observer.h (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/common/wm_activa...
ash/wm/common/wm_activation_observer.h:23: // activation cannot be activated
because a system modal window is active.
nice comment

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/common/wm_globals.h
File ash/wm/common/wm_globals.h (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/common/wm_global...
ash/wm/common/wm_globals.h:56: // Returns the list of more recently used
windows.
super-nit: *most* recently used

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/common/wm_window.h
File ash/wm/common/wm_window.h (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/common/wm_window...
ash/wm/common/wm_window.h:179: // Requests the window to close and destroy
itself. This it intended to
nit: s/it/is

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/DEPS
File ash/wm/overview/DEPS (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/DEPS#ne...
ash/wm/overview/DEPS:6: # Aura files should only be included from other aura
files.
Do you want to add a comment somewhere explaining why this is the case, like a
go/ link or a bug # that explains the refactor that is underway? I think we're
going to have this situation a lot and it might help other people understand why
their DEPS checks are failing.

I wonder if we should leave some kind of note in BUILD.gn, or a README.md, or
something like that too.

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/DEPS#ne...
ash/wm/overview/DEPS:18: "+ash/wm/overview",
This is in the include_rules above.

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/scoped_...
File ash/wm/overview/scoped_overview_animation_settings_factory.cc (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/scoped_...
ash/wm/overview/scoped_overview_animation_settings_factory.cc:26:
ScopedOverviewAnimationSettingsFactory::
nit: blank line above

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/scoped_...
File ash/wm/overview/scoped_overview_animation_settings_factory.h (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/scoped_...
ash/wm/overview/scoped_overview_animation_settings_factory.h:35: };
DISALLOW_COPY_AND_ASSIGN?

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/scoped_...
File ash/wm/overview/scoped_transform_overview_window.cc (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/scoped_...
ash/wm/overview/scoped_transform_overview_window.cc:41: // An iterator class
that traverses an wm::WmWindow and all of it's transient
super-nit: "an" -> "a" and "it's" -> "its"

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/scoped_...
File ash/wm/overview/scoped_transform_overview_window.h (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/scoped_...
ash/wm/overview/scoped_transform_overview_window.h:13: #include
"base/compiler_specific.h"
not needed

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/window_...
File ash/wm/overview/window_grid.cc (left):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/window_...
ash/wm/overview/window_grid.cc:510: selection_widget_->SetOpacity(255);
Huh, nice catch.

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/window_...
File ash/wm/overview/window_grid.cc (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/window_...
ash/wm/overview/window_grid.cc:191: int64_t distance =
(window->ConvertRectToScreen(window->GetTargetBounds())
optional: I know this is clang-format, and I know it was bad before, but the
formatting of this statement is brutal. Maybe try breaking into two statements
with a new local gfx::Point window_center and see if it reads any better?

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/window_...
File ash/wm/overview/window_selector.cc (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/window_...
ash/wm/overview/window_selector.cc:471: if (!observed_windows_.count(window) ||
It took me a minute to figure out this was the right way to look for an add to
an observed container, maybe a comment that it's just looking for adds?

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/window_...
File ash/wm/overview/window_selector.h (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/window_...
ash/wm/overview/window_selector.h:19: #include "base/memory/scoped_vector.h"
Still needed?

https://codereview.chromium.org/2012343002/diff/20001/mash/wm/bridge/wm_windo...
File mash/wm/bridge/wm_window_mus.h (right):

https://codereview.chromium.org/2012343002/diff/20001/mash/wm/bridge/wm_windo...
mash/wm/bridge/wm_window_mus.h:43: // embeeded in the mus::Window.
nit: embedded

https://codereview.chromium.org/2012343002/diff/20001/mash/wm/bridge/wm_windo...
mash/wm/bridge/wm_window_mus.h:44: FOR_REMOTE,
It took me a long time to wrap my head around the names/docs here. Do you think
it would be clearer to just call this case NON_CLIENT_FRAME or WINDOW_FRAME or
similar? Or do you think it's going to be more generally used?

I guess it took me a while to understand that now there's "internal" widget
creation inside wm/sysui and "external" widget creation like from Chrome or
another app.

https://codereview.chromium.org/2012343002/diff/20001/mash/wm/bridge/wm_windo...
mash/wm/bridge/wm_window_mus.h:68: void set_widget(views::Widget* widget,
WidgetCreationType type) {
SetWidget, given that it's no longer a trivial setter

[sky, 2016-05-27 03:18:04]

I think I got them all.

https://codereview.chromium.org/2012343002/diff/20001/ash/shell_window_ids.h
File ash/shell_window_ids.h (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/shell_window_ids.h#...
ash/shell_window_ids.h:187: "overlay between settings-bubble and phanton");
On 2016/05/27 00:02:50, James Cook wrote:
> nit: phanton -> phantom

Done.

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/aura/wm_globals_...
File ash/wm/aura/wm_globals_aura.cc (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/aura/wm_globals_...
ash/wm/aura/wm_globals_aura.cc:69:
ash::Shell::GetInstance()->mru_window_tracker()->BuildMruWindowList());
On 2016/05/27 00:02:50, James Cook wrote:
> nit: no need for ash:: here or below

Done.

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/aura/wm_window_a...
File ash/wm/aura/wm_window_aura.cc (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/aura/wm_window_a...
ash/wm/aura/wm_window_aura.cc:489:
views::Widget::GetWidgetForNativeView(window_)->Close();
On 2016/05/27 00:02:51, James Cook wrote:
> This seems a little dangerous to me, since not every aura::Window is going to
be
> registered with a widget. Maybe the method should be called CloseWidget()? Or
> DCHECK? Both?

Both it is.

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/common/wm_activa...
File ash/wm/common/wm_activation_observer.h (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/common/wm_activa...
ash/wm/common/wm_activation_observer.h:23: // activation cannot be activated
because a system modal window is active.
On 2016/05/27 00:02:51, James Cook wrote:
> nice comment

This is just a copy of that from ActivationObserver.

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/common/wm_globals.h
File ash/wm/common/wm_globals.h (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/common/wm_global...
ash/wm/common/wm_globals.h:56: // Returns the list of more recently used
windows.
On 2016/05/27 00:02:51, James Cook wrote:
> super-nit: *most* recently used

Done.

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/common/wm_window.h
File ash/wm/common/wm_window.h (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/common/wm_window...
ash/wm/common/wm_window.h:179: // Requests the window to close and destroy
itself. This it intended to
On 2016/05/27 00:02:51, James Cook wrote:
> nit: s/it/is

Done.

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/DEPS
File ash/wm/overview/DEPS (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/DEPS#ne...
ash/wm/overview/DEPS:6: # Aura files should only be included from other aura
files.
On 2016/05/27 00:02:51, James Cook wrote:
> Do you want to add a comment somewhere explaining why this is the case, like a
> go/ link or a bug # that explains the refactor that is underway? I think we're
> going to have this situation a lot and it might help other people understand
why
> their DEPS checks are failing.
> 
> I wonder if we should leave some kind of note in BUILD.gn, or a README.md, or
> something like that too.

I added a README.md to ash along with a pointer here.

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/DEPS#ne...
ash/wm/overview/DEPS:18: "+ash/wm/overview",
On 2016/05/27 00:02:51, James Cook wrote:
> This is in the include_rules above.

This is a short cut to allow the aura files to include all files. I could have
instead explicitly added back the _aura.h files listed on 6 and 7, but this
seemed easier.

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/scoped_...
File ash/wm/overview/scoped_overview_animation_settings_factory.cc (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/scoped_...
ash/wm/overview/scoped_overview_animation_settings_factory.cc:26:
ScopedOverviewAnimationSettingsFactory::
On 2016/05/27 00:02:51, James Cook wrote:
> nit: blank line above

Done.

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/scoped_...
File ash/wm/overview/scoped_overview_animation_settings_factory.h (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/scoped_...
ash/wm/overview/scoped_overview_animation_settings_factory.h:35: };
On 2016/05/27 00:02:51, James Cook wrote:
> DISALLOW_COPY_AND_ASSIGN?

It's my understanding that is not needed because of the pure virtual function.
Am I wrong?

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/scoped_...
File ash/wm/overview/scoped_transform_overview_window.cc (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/scoped_...
ash/wm/overview/scoped_transform_overview_window.cc:41: // An iterator class
that traverses an wm::WmWindow and all of it's transient
On 2016/05/27 00:02:51, James Cook wrote:
> super-nit: "an" -> "a" and "it's" -> "its"

Done.

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/scoped_...
File ash/wm/overview/scoped_transform_overview_window.h (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/scoped_...
ash/wm/overview/scoped_transform_overview_window.h:13: #include
"base/compiler_specific.h"
On 2016/05/27 00:02:51, James Cook wrote:
> not needed

Done.

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/window_...
File ash/wm/overview/window_grid.cc (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/window_...
ash/wm/overview/window_grid.cc:191: int64_t distance =
(window->ConvertRectToScreen(window->GetTargetBounds())
On 2016/05/27 00:02:51, James Cook wrote:
> optional: I know this is clang-format, and I know it was bad before, but the
> formatting of this statement is brutal. Maybe try breaking into two statements
> with a new local gfx::Point window_center and see if it reads any better?

I split it into two.

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/window_...
File ash/wm/overview/window_selector.cc (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/window_...
ash/wm/overview/window_selector.cc:471: if (!observed_windows_.count(window) ||
On 2016/05/27 00:02:51, James Cook wrote:
> It took me a minute to figure out this was the right way to look for an add to
> an observed container, maybe a comment that it's just looking for adds?

Done.

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/window_...
File ash/wm/overview/window_selector.h (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/window_...
ash/wm/overview/window_selector.h:19: #include "base/memory/scoped_vector.h"
On 2016/05/27 00:02:51, James Cook wrote:
> Still needed?

Removed from here, but I had to add to WindowGrid. WindowGrid was and is using
ScopedVector but got the include from here (apparently).

https://codereview.chromium.org/2012343002/diff/20001/mash/wm/bridge/wm_windo...
File mash/wm/bridge/wm_window_mus.h (right):

https://codereview.chromium.org/2012343002/diff/20001/mash/wm/bridge/wm_windo...
mash/wm/bridge/wm_window_mus.h:43: // embeeded in the mus::Window.
On 2016/05/27 00:02:51, James Cook wrote:
> nit: embedded

Done.

https://codereview.chromium.org/2012343002/diff/20001/mash/wm/bridge/wm_windo...
mash/wm/bridge/wm_window_mus.h:44: FOR_REMOTE,
On 2016/05/27 00:02:52, James Cook wrote:
> It took me a long time to wrap my head around the names/docs here. Do you
think
> it would be clearer to just call this case NON_CLIENT_FRAME or WINDOW_FRAME or
> similar? Or do you think it's going to be more generally used?

I think that would be confusing as other widgets have NON_CLIENT_FRAMEs too.

> I guess it took me a while to understand that now there's "internal" widget
> creation inside wm/sysui and "external" widget creation like from Chrome or
> another app.

I struggled with naming here too. I'm open to something better.

https://codereview.chromium.org/2012343002/diff/20001/mash/wm/bridge/wm_windo...
mash/wm/bridge/wm_window_mus.h:68: void set_widget(views::Widget* widget,
WidgetCreationType type) {
On 2016/05/27 00:02:51, James Cook wrote:
> SetWidget, given that it's no longer a trivial setter

It is setting two values, but I they are both ints so I think that qualifies as
trivial. Do you think otherwise?

[James Cook, 2016-05-27 16:04:03]

LGTM

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/DEPS
File ash/wm/overview/DEPS (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/DEPS#ne...
ash/wm/overview/DEPS:18: "+ash/wm/overview",
On 2016/05/27 03:18:03, sky wrote:
> On 2016/05/27 00:02:51, James Cook wrote:
> > This is in the include_rules above.
> 
> This is a short cut to allow the aura files to include all files. I could have
> instead explicitly added back the _aura.h files listed on 6 and 7, but this
> seemed easier.

Ah, OK.

https://codereview.chromium.org/2012343002/diff/20001/mash/wm/bridge/wm_windo...
File mash/wm/bridge/wm_window_mus.h (right):

https://codereview.chromium.org/2012343002/diff/20001/mash/wm/bridge/wm_windo...
mash/wm/bridge/wm_window_mus.h:44: FOR_REMOTE,
On 2016/05/27 03:18:04, sky wrote:
> On 2016/05/27 00:02:52, James Cook wrote:
> > It took me a long time to wrap my head around the names/docs here. Do you
> think
> > it would be clearer to just call this case NON_CLIENT_FRAME or WINDOW_FRAME
or
> > similar? Or do you think it's going to be more generally used?
> 
> I think that would be confusing as other widgets have NON_CLIENT_FRAMEs too.
> 
> > I guess it took me a while to understand that now there's "internal" widget
> > creation inside wm/sysui and "external" widget creation like from Chrome or
> > another app.
> 
> I struggled with naming here too. I'm open to something better.

I think I would do something like: INTERNAL and FOR_CLIENT and give examples in
the comments:

The widget was created internally (that is, within ash system UI) and not at the
request of a client app.

and

The widget was created for a client app (e.g. Chrome or other mojo app). In
other words there is a client embedded in the mus::Window.

(I reason better from examples.)

https://codereview.chromium.org/2012343002/diff/40001/ash/README.md
File ash/README.md (right):

https://codereview.chromium.org/2012343002/diff/40001/ash/README.md#newcode1
ash/README.md:1: Mus+ash
Hooray for readme files! I wish Chrome had more.

https://codereview.chromium.org/2012343002/diff/40001/ash/README.md#newcode8
ash/README.md:8: added back.
*not* added back?

[James Cook, 2016-05-27 16:30:27]

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/scoped_...
File ash/wm/overview/scoped_overview_animation_settings_factory.h (right):

https://codereview.chromium.org/2012343002/diff/20001/ash/wm/overview/scoped_...
ash/wm/overview/scoped_overview_animation_settings_factory.h:35: };
On 2016/05/27 03:18:03, sky wrote:
> On 2016/05/27 00:02:51, James Cook wrote:
> > DISALLOW_COPY_AND_ASSIGN?
> 
> It's my understanding that is not needed because of the pure virtual function.
> Am I wrong?

Nope, you're right.

https://codereview.chromium.org/2012343002/diff/20001/mash/wm/bridge/wm_windo...
File mash/wm/bridge/wm_window_mus.h (right):

https://codereview.chromium.org/2012343002/diff/20001/mash/wm/bridge/wm_windo...
mash/wm/bridge/wm_window_mus.h:68: void set_widget(views::Widget* widget,
WidgetCreationType type) {
On 2016/05/27 03:18:04, sky wrote:
> On 2016/05/27 00:02:51, James Cook wrote:
> > SetWidget, given that it's no longer a trivial setter
> 
> It is setting two values, but I they are both ints so I think that qualifies
as
> trivial. Do you think otherwise?

Yeah, it's fine. The style guide isn't specific about setters: "Functions that
are very cheap to call may instead follow the style for variable names (all
lower-case, with underscores between words). The rule of thumb is that such a
function should be so cheap that you normally wouldn't bother caching its return
value when calling it in a loop." So, yeah, this is cheap to call.

[sky, 2016-05-27 16:41:30]

The CQ bit was checked by sky@chromium.org

[sky, 2016-05-27 16:41:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2012343002/#ps80001
(title: "feedback")

[commit-bot: I haz the power, 2016-05-27 16:41:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2012343002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2012343002/80001

[sky, 2016-05-27 16:58:23]

https://codereview.chromium.org/2012343002/diff/20001/mash/wm/bridge/wm_windo...
File mash/wm/bridge/wm_window_mus.h (right):

https://codereview.chromium.org/2012343002/diff/20001/mash/wm/bridge/wm_windo...
mash/wm/bridge/wm_window_mus.h:44: FOR_REMOTE,
On 2016/05/27 16:04:03, James Cook wrote:
> On 2016/05/27 03:18:04, sky wrote:
> > On 2016/05/27 00:02:52, James Cook wrote:
> > > It took me a long time to wrap my head around the names/docs here. Do you
> > think
> > > it would be clearer to just call this case NON_CLIENT_FRAME or
WINDOW_FRAME
> or
> > > similar? Or do you think it's going to be more generally used?
> > 
> > I think that would be confusing as other widgets have NON_CLIENT_FRAMEs too.
> > 
> > > I guess it took me a while to understand that now there's "internal"
widget
> > > creation inside wm/sysui and "external" widget creation like from Chrome
or
> > > another app.
> > 
> > I struggled with naming here too. I'm open to something better.
> 
> I think I would do something like: INTERNAL and FOR_CLIENT and give examples
in
> the comments:
> 
> The widget was created internally (that is, within ash system UI) and not at
the
> request of a client app.
> 
> and
> 
> The widget was created for a client app (e.g. Chrome or other mojo app). In
> other words there is a client embedded in the mus::Window.
> 
> (I reason better from examples.)

Done.

https://codereview.chromium.org/2012343002/diff/40001/ash/README.md
File ash/README.md (right):

https://codereview.chromium.org/2012343002/diff/40001/ash/README.md#newcode8
ash/README.md:8: added back.
On 2016/05/27 16:04:03, James Cook wrote:
> *not* added back?

Woops. Done.

[commit-bot: I haz the power, 2016-05-27 18:48:00]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-27 18:50:45]

Description was changed from

==========
Converts overview to use common ash types

There are a couple of remaining dependencies on the non-ash types. I
plan on removing them next.

BUG=581868
TEST=covered by tests
R=jamescook@chromium.org
==========

to

==========
Converts overview to use common ash types

There are a couple of remaining dependencies on the non-ash types. I
plan on removing them next.

BUG=581868
TEST=covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/6624a7af7520226b2513a689055c0425f66d60fc
Cr-Commit-Position: refs/heads/master@{#396523}
==========

[commit-bot: I haz the power, 2016-05-27 18:50:46]

Patchset 5 (id:??) landed as
https://crrev.com/6624a7af7520226b2513a689055c0425f66d60fc
Cr-Commit-Position: refs/heads/master@{#396523}