ash/wm/overview/DEPS - Issue 2012343002: Converts overview to use common ash types

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/wm/overview/DEPS

Issue 2012343002: Converts overview to use common ash types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tweaks Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ash/wm/common/wm_window.h ('K') | « ash/wm/common/wm_window_property.h ('k') | ash/wm/overview/scoped_overview_animation_settings.h » ('j') | ash/wm/overview/scoped_overview_animation_settings_factory.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 include_rules = [

	2 "-ash",

	3 "+ash/material_design",

	4 "+ash/wm/common",

	5 "+ash/wm/overview",

	6 # Aura files should only be included from other aura files.
	James Cook 2016/05/27 00:02:51 Do you want to add a comment somewhere explaining Do you want to add a comment somewhere explaining why this is the case, like a go/ link or a bug # that explains the refactor that is underway? I think we're going to have this situation a lot and it might help other people understand why their DEPS checks are failing. I wonder if we should leave some kind of note in BUILD.gn, or a README.md, or something like that too. sky 2016/05/27 03:18:03 I added a README.md to ash along with a pointer he Show quoted text On 2016/05/27 00:02:51, James Cook wrote: > Do you want to add a comment somewhere explaining why this is the case, like a > go/ link or a bug # that explains the refactor that is underway? I think we're > going to have this situation a lot and it might help other people understand why > their DEPS checks are failing. > > I wonder if we should leave some kind of note in BUILD.gn, or a README.md, or > something like that too. I added a README.md to ash along with a pointer here.
	7 "-ash/wm/overview/scoped_overview_animation_settings_aura.h",

	8 "-ash/wm/overview/scoped_overview_animation_settings_factory_aura.h",

	9 "+ash/ash_export.h",

	10 "+ash/ash_switches.h",

	11 "+ui",

	12 "-ui/aura",

	13 ]

	14

	15 specific_include_rules = {

	16 ".aura\..": [

	17 "+ash/wm/aura",

	18 "+ash/wm/overview",
	James Cook 2016/05/27 00:02:51 This is in the include_rules above. This is in the include_rules above. sky 2016/05/27 03:18:03 This is a short cut to allow the aura files to inc Show quoted text On 2016/05/27 00:02:51, James Cook wrote: > This is in the include_rules above. This is a short cut to allow the aura files to include all files. I could have instead explicitly added back the _aura.h files listed on 6 and 7, but this seemed easier. James Cook 2016/05/27 16:04:02 Ah, OK. Show quoted text On 2016/05/27 03:18:03, sky wrote: > On 2016/05/27 00:02:51, James Cook wrote: > > This is in the include_rules above. > > This is a short cut to allow the aura files to include all files. I could have > instead explicitly added back the _aura.h files listed on 6 and 7, but this > seemed easier. Ah, OK.
	19 "+ui/aura",

	20 ],

	21 # TODO(sky): refactor. Do not add more.

	22 "window_selector.cc": [

	23 "+ash/accessibility_delegate.h",

	24 "+ash/shell.h",

	25 ],

	26 # TODO(sky): refactor. Do not add more.

	27 "window_selector_controller.cc": [

	28 "+ash/session/session_state_delegate.h",

	29 "+ash/shell.h",

	30 "+ash/system/tray/system_tray_delegate.h",

	31 ],

	32 ".test.": [

	33 "+ash",

	34 "+ui/aura",

	35 ],

	36 }

OLD	NEW