Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: ash/metrics/user_metrics_recorder.cc

Issue 2012343002: Converts overview to use common ash types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: feedback Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/metrics/user_metrics_recorder.h ('k') | ash/shell.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/metrics/user_metrics_recorder.cc
diff --git a/ash/metrics/user_metrics_recorder.cc b/ash/metrics/user_metrics_recorder.cc
index e07afe8290b86591d64a32315b2ea26422277f4a..16ecc6d414c371f0b2ccf77b105399dd0bffa5c6 100644
--- a/ash/metrics/user_metrics_recorder.cc
+++ b/ash/metrics/user_metrics_recorder.cc
@@ -582,20 +582,6 @@ void UserMetricsRecorder::RecordUserMetricsAction(UserMetricsAction action) {
case ash::UMA_WINDOW_MAXIMIZE_BUTTON_MAXIMIZE_RIGHT:
base::RecordAction(base::UserMetricsAction("MaxButton_MaxRight"));
break;
- case ash::UMA_WINDOW_OVERVIEW:
- base::RecordAction(
- base::UserMetricsAction("WindowSelector_Overview"));
- break;
- case ash::UMA_WINDOW_OVERVIEW_ACTIVE_WINDOW_CHANGED:
- base::RecordAction(
- base::UserMetricsAction("WindowSelector_ActiveWindowChanged"));
- task_switch_metrics_recorder_.OnTaskSwitch(
- TaskSwitchMetricsRecorder::OVERVIEW_MODE);
- break;
- case ash::UMA_WINDOW_OVERVIEW_ENTER_KEY:
- base::RecordAction(
- base::UserMetricsAction("WindowSelector_OverviewEnterKey"));
- break;
case ash::UMA_WINDOW_CYCLE:
base::RecordAction(
base::UserMetricsAction("WindowCycleController_Cycle"));
@@ -612,6 +598,19 @@ void UserMetricsRecorder::RecordUserMetricsAction(
case wm::WmUserMetricsAction::DRAG_MAXIMIZE_RIGHT:
base::RecordAction(base::UserMetricsAction("WindowDrag_MaximizeRight"));
break;
+ case wm::WmUserMetricsAction::WINDOW_OVERVIEW:
+ base::RecordAction(base::UserMetricsAction("WindowSelector_Overview"));
+ break;
+ case wm::WmUserMetricsAction::WINDOW_OVERVIEW_ACTIVE_WINDOW_CHANGED:
+ base::RecordAction(
+ base::UserMetricsAction("WindowSelector_ActiveWindowChanged"));
+ task_switch_metrics_recorder_.OnTaskSwitch(
+ TaskSwitchMetricsRecorder::OVERVIEW_MODE);
+ break;
+ case wm::WmUserMetricsAction::WINDOW_OVERVIEW_ENTER_KEY:
+ base::RecordAction(
+ base::UserMetricsAction("WindowSelector_OverviewEnterKey"));
+ break;
}
}
« no previous file with comments | « ash/metrics/user_metrics_recorder.h ('k') | ash/shell.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698