Get rid of a redundant function alias positionBeforeNode()

Get rid of a redundant function alias positionBeforeNode()

This patch gets rid of a redundant function alias |positionBeforeNode()| by
replacing it by its implementation |Position::beforeNode()| to reduce
call depth for ease of debugging and improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Committed: https://crrev.com/860f45795a73d3436975e544f37604023b77f4f3
Cr-Commit-Position: refs/heads/master@{#394973}

[yosin_UTC9, 2016-05-19 05:22:05]

Description was changed from

==========
2016-05-19T14:03:34

BUG=
==========

to

==========
Get rid of a redundant function alias positionBeforeNode()

This patch gets rid of a redundant function alias |positionBeforeNode()| by
replacing it by its implementation |Position::beforeNode()| to reduce
call depth for ease of debugging and improving code health.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-05-19 05:22:05]

yosin@chromium.org changed reviewers:
+ keishi@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2016-05-19 05:23:18]

PTAL

All files are editing/ except for core/html/HTMLTextFormControlElement.cpp

[keishi, 2016-05-19 05:26:10]

LGTM

[yosin_UTC9, 2016-05-19 05:36:34]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-05-19 05:37:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1997563002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1997563002/1

[commit-bot: I haz the power, 2016-05-19 07:12:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 07:12:16]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yosin_UTC9, 2016-05-19 07:38:49]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-05-19 07:39:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1997563002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1997563002/1

[commit-bot: I haz the power, 2016-05-19 09:18:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 09:18:22]

Failed to apply patch for third_party/WebKit/Source/core/editing/Position.h:
While running git apply --index -3 -p1;
  error: patch failed: third_party/WebKit/Source/core/editing/Position.h:258
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/Source/core/editing/Position.h' with
conflicts.
  U third_party/WebKit/Source/core/editing/Position.h

Patch:       third_party/WebKit/Source/core/editing/Position.h
Index: third_party/WebKit/Source/core/editing/Position.h
diff --git a/third_party/WebKit/Source/core/editing/Position.h
b/third_party/WebKit/Source/core/editing/Position.h
index
63c7af9759f0cda8808563de3a39224ef9f54134..fa6fd2514d9bc1dff27c1c010b4a7271ccb1f2a1
100644
--- a/third_party/WebKit/Source/core/editing/Position.h
+++ b/third_party/WebKit/Source/core/editing/Position.h
@@ -258,7 +258,7 @@ PositionTemplate<Strategy>
PositionTemplate<Strategy>::inParentAfterNode(const N
     return PositionTemplate<Strategy>(Strategy::parent(node),
Strategy::index(node) + 1);
 }
 
-// positionBeforeNode and positionAfterNode return neighbor-anchored positions,
construction is O(1)
+// Position::beforeNode and positionAfterNode return neighbor-anchored
positions, construction is O(1)
 template <typename Strategy>
 PositionTemplate<Strategy> PositionTemplate<Strategy>::beforeNode(Node*
anchorNode)
 {
@@ -266,11 +266,6 @@ PositionTemplate<Strategy>
PositionTemplate<Strategy>::beforeNode(Node* anchorNo
     return PositionTemplate<Strategy>(anchorNode,
PositionAnchorType::BeforeAnchor);
 }
 
-inline Position positionBeforeNode(Node* anchorNode)
-{
-    return Position::beforeNode(anchorNode);
-}
-
 template <typename Strategy>
 PositionTemplate<Strategy> PositionTemplate<Strategy>::afterNode(Node*
anchorNode)
 {

[commit-bot: I haz the power, 2016-05-19 09:18:27]

The CQ bit was unchecked by commit-bot@chromium.org

[yosin_UTC9, 2016-05-19 10:26:34]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-05-19 10:26:35]

The patchset sent to the CQ was uploaded after l-g-t-m from keishi@chromium.org
Link to the patchset: https://codereview.chromium.org/1997563002/#ps40001
(title: "2016-05-19T19:25:37 Rebase")

[commit-bot: I haz the power, 2016-05-19 10:26:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1997563002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1997563002/40001

[commit-bot: I haz the power, 2016-05-19 12:30:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 12:30:53]

Failed to apply patch for
third_party/WebKit/Source/core/editing/SelectionEditor.cpp:
While running git apply --index -3 -p1;
  error: patch failed:
third_party/WebKit/Source/core/editing/SelectionEditor.cpp:231
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/Source/core/editing/SelectionEditor.cpp'
with conflicts.
  U third_party/WebKit/Source/core/editing/SelectionEditor.cpp

Patch:       third_party/WebKit/Source/core/editing/SelectionEditor.cpp
Index: third_party/WebKit/Source/core/editing/SelectionEditor.cpp
diff --git a/third_party/WebKit/Source/core/editing/SelectionEditor.cpp
b/third_party/WebKit/Source/core/editing/SelectionEditor.cpp
index
5ef91b71a530ae305ce31d67fcb3ed8ea5632e38..6c7881f5b5d7b42f6aa094b5685a1adb0e5d85f8
100644
--- a/third_party/WebKit/Source/core/editing/SelectionEditor.cpp
+++ b/third_party/WebKit/Source/core/editing/SelectionEditor.cpp
@@ -231,7 +231,7 @@ VisiblePosition
SelectionModifier::nextWordPositionForPlatform(const VisiblePosi
 static void adjustPositionForUserSelectAll(VisiblePosition& pos, bool
isForward)
 {
     if (Node* rootUserSelectAll =
EditingStrategy::rootUserSelectAllForNode(pos.deepEquivalent().anchorNode()))
-        pos = createVisiblePosition(isForward ?
mostForwardCaretPosition(Position::afterNode(rootUserSelectAll),
CanCrossEditingBoundary) :
mostBackwardCaretPosition(positionBeforeNode(rootUserSelectAll),
CanCrossEditingBoundary));
+        pos = createVisiblePosition(isForward ?
mostForwardCaretPosition(Position::afterNode(rootUserSelectAll),
CanCrossEditingBoundary) :
mostBackwardCaretPosition(Position::beforeNode(rootUserSelectAll),
CanCrossEditingBoundary));
 }
 
 // TODO(yosin): We should move this function to "SelectionModifier.cpp".

[yosin_UTC9, 2016-05-19 13:13:57]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-05-19 13:13:57]

The patchset sent to the CQ was uploaded after l-g-t-m from keishi@chromium.org
Link to the patchset: https://codereview.chromium.org/1997563002/#ps60001
(title: "2016-05-19T22:13:54 Rebase")

[commit-bot: I haz the power, 2016-05-19 13:14:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1997563002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1997563002/60001

[commit-bot: I haz the power, 2016-05-19 13:30:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 13:30:19]

Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[yosin_UTC9, 2016-05-19 13:37:53]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-05-19 13:37:53]

The patchset sent to the CQ was uploaded after l-g-t-m from keishi@chromium.org
Link to the patchset: https://codereview.chromium.org/1997563002/#ps80001
(title: "2016-05-19T22:35:34 rebase")

[commit-bot: I haz the power, 2016-05-19 13:38:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1997563002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1997563002/80001

[commit-bot: I haz the power, 2016-05-19 15:43:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 15:43:03]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yosin_UTC9, 2016-05-19 23:35:00]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-05-19 23:35:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1997563002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1997563002/80001

[commit-bot: I haz the power, 2016-05-20 03:09:52]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-20 03:11:16]

Description was changed from

==========
Get rid of a redundant function alias positionBeforeNode()

This patch gets rid of a redundant function alias |positionBeforeNode()| by
replacing it by its implementation |Position::beforeNode()| to reduce
call depth for ease of debugging and improving code health.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Get rid of a redundant function alias positionBeforeNode()

This patch gets rid of a redundant function alias |positionBeforeNode()| by
replacing it by its implementation |Position::beforeNode()| to reduce
call depth for ease of debugging and improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Committed: https://crrev.com/860f45795a73d3436975e544f37604023b77f4f3
Cr-Commit-Position: refs/heads/master@{#394973}
==========

[commit-bot: I haz the power, 2016-05-20 03:11:17]

Patchset 5 (id:??) landed as
https://crrev.com/860f45795a73d3436975e544f37604023b77f4f3
Cr-Commit-Position: refs/heads/master@{#394973}