third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp - Issue 1997563002: Get rid of a redundant function alias positionBeforeNode()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp

Issue 1997563002: Get rid of a redundant function alias positionBeforeNode() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2016-05-19T22:35:34 rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp b/third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp

index cdd4fbd5d2f8c907a9a35ceac6e6170d25c3cd6f..3c930c60b3453481849c3f2aaa875734b7a2dcda 100644

--- a/third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp

@@ -113,7 +113,7 @@ void BreakBlockquoteCommand::doApply(EditingState* editingState)

insertNodeBefore(breakElement, topBlockquote, editingState);

if (editingState->isAborted())

return;

- setEndingSelection(VisibleSelection(positionBeforeNode(breakElement), TextAffinity::Downstream, endingSelection().isDirectional()));

+ setEndingSelection(VisibleSelection(Position::beforeNode(breakElement), TextAffinity::Downstream, endingSelection().isDirectional()));

rebalanceWhitespace();

return;

}

@@ -125,7 +125,7 @@ void BreakBlockquoteCommand::doApply(EditingState* editingState)

// If we're inserting the break at the end of the quoted content, we don't need to break the quote.

if (isLastVisPosInNode) {

- setEndingSelection(VisibleSelection(positionBeforeNode(breakElement), TextAffinity::Downstream, endingSelection().isDirectional()));

+ setEndingSelection(VisibleSelection(Position::beforeNode(breakElement), TextAffinity::Downstream, endingSelection().isDirectional()));

rebalanceWhitespace();

return;

}

@@ -236,7 +236,7 @@ void BreakBlockquoteCommand::doApply(EditingState* editingState)

return;

// Put the selection right before the break.

- setEndingSelection(VisibleSelection(positionBeforeNode(breakElement), TextAffinity::Downstream, endingSelection().isDirectional()));

+ setEndingSelection(VisibleSelection(Position::beforeNode(breakElement), TextAffinity::Downstream, endingSelection().isDirectional()));

rebalanceWhitespace();

}