third_party/WebKit/Source/core/editing/VisibleUnits.cpp - Issue 1997563002: Get rid of a redundant function alias positionBeforeNode()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

Issue 1997563002: Get rid of a redundant function alias positionBeforeNode() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2016-05-19T22:35:34 rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/SelectionModifier.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

index aec898d9c92a4d1b74c5b09caea386ff71312cb7..d7fd6c17ad1fd3cccf3abc4bece6e1140c498121 100644

--- a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

@@ -279,7 +279,7 @@ static Position previousRootInlineBoxCandidatePosition(Node* node, const Visible

if (highestEditableRoot(firstPositionInOrBeforeNode(previousNode), editableType) != highestRoot)

break;

- Position pos = isHTMLBRElement(*previousNode) ? positionBeforeNode(previousNode) :

+ Position pos = isHTMLBRElement(*previousNode) ? Position::beforeNode(previousNode) :

Position::editingPositionOf(previousNode, caretMaxOffset(previousNode));

if (isVisuallyEquivalentCandidate(pos))