third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp - Issue 1997563002: Get rid of a redundant function alias positionBeforeNode()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp

Issue 1997563002: Get rid of a redundant function alias positionBeforeNode() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2016-05-19T22:35:34 rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp ('k') | third_party/WebKit/Source/core/editing/serializers/Serialization.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp

diff --git a/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp b/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp

index 12bd4aff4921e7f02fbf5356f42696a4d1b85897..c6831d540650730c47c9353e4d9475735eec697c 100644

--- a/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp

+++ b/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp

@@ -903,7 +903,7 @@ bool TextIteratorAlgorithm<Strategy>::shouldRepresentNodeOffsetZero()

// The currPos.isNotNull() check is needed because positions in non-HTML content

// (like SVG) do not have visible positions, and we don't want to emit for them either.

VisiblePosition startPos = createVisiblePosition(Position(m_startContainer, m_startOffset));

- VisiblePosition currPos = createVisiblePosition(positionBeforeNode(m_node));

+ VisiblePosition currPos = createVisiblePosition(Position::beforeNode(m_node));

return startPos.isNotNull() && currPos.isNotNull() && !inSameLine(startPos, currPos);

}