third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp - Issue 1997563002: Get rid of a redundant function alias positionBeforeNode()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

Issue 1997563002: Get rid of a redundant function alias positionBeforeNode() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2016-05-19T22:35:34 rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp b/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

index ec54fa58e5244629862f73d92c8abae00e9139cc..cf0dcd96926d484d0cf3c213f98f079ce6cac758 100644

--- a/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

@@ -231,7 +231,7 @@ void IndentOutdentCommand::outdentParagraph(EditingState* editingState)

insertNodeBefore(placeholder, splitBlockquoteNode, editingState);

if (editingState->isAborted())

return;

- moveParagraph(startOfParagraphToMove, endOfParagraphToMove, createVisiblePosition(positionBeforeNode(placeholder)), editingState, true);

+ moveParagraph(startOfParagraphToMove, endOfParagraphToMove, createVisiblePosition(Position::beforeNode(placeholder)), editingState, true);

}

// FIXME: We should merge this function with ApplyBlockElementCommand::formatSelection