third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp - Issue 1997563002: Get rid of a redundant function alias positionBeforeNode()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

Issue 1997563002: Get rid of a redundant function alias positionBeforeNode() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2016-05-19T22:35:34 rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

index cf4bcaafc31078a90dd816cf396a9074da2e9d74..b9a686984fefd0aa3a391487f28d06088d01876f 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

@@ -382,7 +382,7 @@ void InsertListCommand::unlistifyParagraph(const VisiblePosition& originalStart,

if (editingState->isAborted())

return;

- VisiblePosition insertionPoint = createVisiblePosition(positionBeforeNode(placeholder));

+ VisiblePosition insertionPoint = createVisiblePosition(Position::beforeNode(placeholder));

moveParagraphs(start, end, insertionPoint, editingState, /* preserveSelection */ true, /* preserveStyle */ true, listChildNode);

}

@@ -495,7 +495,7 @@ void InsertListCommand::moveParagraphOverPositionIntoEmptyListItem(const Visible

document().updateStyleAndLayoutIgnorePendingStylesheets();

const VisiblePosition& start = startOfParagraph(pos, CanSkipOverEditingBoundary);

const VisiblePosition& end = endOfParagraph(pos, CanSkipOverEditingBoundary);

- moveParagraph(start, end, createVisiblePosition(positionBeforeNode(placeholder)), editingState, true);

+ moveParagraph(start, end, createVisiblePosition(Position::beforeNode(placeholder)), editingState, true);

}

DEFINE_TRACE(InsertListCommand)