Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

Issue 1997563002: Get rid of a redundant function alias positionBeforeNode() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: 2016-05-19T22:35:34 rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp
index c6a2b7c674877774317acaa05e1bc8327f39a03c..521492eba11c1514029f07ec64c8cf075c0637fd 100644
--- a/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp
@@ -443,7 +443,7 @@ void InsertParagraphSeparatorCommand::doApply(EditingState* editingState)
}
// Move the start node and the siblings of the start node.
- if (createVisiblePosition(insertionPosition).deepEquivalent() != createVisiblePosition(positionBeforeNode(blockToInsert)).deepEquivalent()) {
+ if (createVisiblePosition(insertionPosition).deepEquivalent() != createVisiblePosition(Position::beforeNode(blockToInsert)).deepEquivalent()) {
Node* n;
if (insertionPosition.computeContainerNode() == startBlock) {
n = insertionPosition.computeNodeAfterPosition();
@@ -455,7 +455,7 @@ void InsertParagraphSeparatorCommand::doApply(EditingState* editingState)
splitTreeToNode(splitTo, startBlock);
for (n = startBlock->firstChild(); n; n = n->nextSibling()) {
- VisiblePosition beforeNodePosition = createVisiblePosition(positionBeforeNode(n));
+ VisiblePosition beforeNodePosition = createVisiblePosition(Position::beforeNode(n));
if (!beforeNodePosition.isNull() && comparePositions(createVisiblePosition(insertionPosition), beforeNodePosition) <= 0)
break;
}

Powered by Google App Engine
This is Rietveld 408576698