Chromium Code Reviews

Issue 1997513002: Mozart: Generalize frame scheduling. (Closed)

Created:
4 years, 7 months ago by jeffbrown
Modified:
4 years, 7 months ago
Reviewers:
abarth, mikejurka
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@moz-jank2
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mozart: Generalize frame scheduling. Renamed SceneScheduler to FrameScheduler. Added a SceneScheduler to the Renderer so that clients of the renderer (like the view manager) can schedule frames more globally without having to publish a scene. Added some basic integration tests for the scheduling API. BUG= R=mikejurka@google.com Committed: https://chromium.googlesource.com/external/mojo/+/78a7acc47ef8fb9e26ac3137d8b53b61fba0a289

Patch Set 1 #

Total comments: 4

Patch Set 2 : add comments #

Unified diffs Side-by-side diffs Stats (+471 lines, -136 lines)
M mojo/dart/packages/mojo_services/lib/mojo/gfx/composition/renderers.mojom.dart View 7 chunks +93 lines, -1 line 0 comments
M mojo/dart/packages/mojo_services/lib/mojo/gfx/composition/scenes.mojom.dart View 1 chunk +1 line, -1 line 0 comments
M mojo/dart/packages/mojo_services/lib/mojo/gfx/composition/scheduling.mojom.dart View 14 chunks +73 lines, -73 lines 0 comments
M mojo/services/gfx/composition/interfaces/renderers.mojom View 2 chunks +4 lines, -0 lines 0 comments
M mojo/services/gfx/composition/interfaces/scenes.mojom View 2 chunks +4 lines, -4 lines 0 comments
M mojo/services/gfx/composition/interfaces/scheduling.mojom View 1 chunk +9 lines, -10 lines 0 comments
M mojo/tools/data/apptests View 1 chunk +4 lines, -0 lines 0 comments
M mojo/ui/choreographer.h View 2 chunks +5 lines, -5 lines 0 comments
M mojo/ui/choreographer.cc View 2 chunks +5 lines, -5 lines 0 comments
M services/gfx/compositor/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments
M services/gfx/compositor/backend/gpu_output.cc View 1 chunk +1 line, -0 lines 0 comments
M services/gfx/compositor/compositor_engine.h View 2 chunks +5 lines, -1 line 0 comments
M services/gfx/compositor/compositor_engine.cc View 3 chunks +19 lines, -3 lines 0 comments
A services/gfx/compositor/frame_dispatcher.h View 1 chunk +39 lines, -0 lines 0 comments
A services/gfx/compositor/frame_dispatcher.cc View 1 chunk +26 lines, -0 lines 0 comments
M services/gfx/compositor/renderer_impl.h View 2 chunks +8 lines, -0 lines 0 comments
M services/gfx/compositor/renderer_impl.cc View 2 chunks +18 lines, -0 lines 0 comments
M services/gfx/compositor/renderer_state.h View 3 chunks +4 lines, -0 lines 0 comments
M services/gfx/compositor/scene_impl.h View 2 chunks +4 lines, -4 lines 0 comments
M services/gfx/compositor/scene_impl.cc View 1 chunk +2 lines, -2 lines 0 comments
M services/gfx/compositor/scene_state.h View 2 chunks +5 lines, -8 lines 0 comments
M services/gfx/compositor/scene_state.cc View 1 chunk +1 line, -18 lines 0 comments
A services/gfx/compositor/tests/README.md View 1 chunk +10 lines, -0 lines 0 comments
A services/gfx/compositor/tests/scheduling_apptest.cc View 1 chunk +125 lines, -0 lines 0 comments
M services/ui/launcher/launch_instance.cc View 1 chunk +1 line, -1 line 0 comments

Depends on Patchset:

Issue 1995873002 Patch 1

Messages

Total messages: 7 (2 generated)
jeffbrown
4 years, 7 months ago (2016-05-19 00:14:09 UTC) #2
mikejurka
lgtm, just had some questions in the comments https://codereview.chromium.org/1997513002/diff/1/services/gfx/compositor/tests/scheduling_apptest.cc File services/gfx/compositor/tests/scheduling_apptest.cc (right): https://codereview.chromium.org/1997513002/diff/1/services/gfx/compositor/tests/scheduling_apptest.cc#newcode55 services/gfx/compositor/tests/scheduling_apptest.cc:55: ASSERT_TRUE(scheduler->ScheduleFrame(&frame_info1)); ...
4 years, 7 months ago (2016-05-19 23:59:00 UTC) #3
jeffbrown
https://codereview.chromium.org/1997513002/diff/1/services/gfx/compositor/tests/scheduling_apptest.cc File services/gfx/compositor/tests/scheduling_apptest.cc (right): https://codereview.chromium.org/1997513002/diff/1/services/gfx/compositor/tests/scheduling_apptest.cc#newcode55 services/gfx/compositor/tests/scheduling_apptest.cc:55: ASSERT_TRUE(scheduler->ScheduleFrame(&frame_info1)); On 2016/05/19 23:59:00, mikejurka wrote: > does scheduleframe ...
4 years, 7 months ago (2016-05-20 00:38:12 UTC) #4
mikejurka
lgtm
4 years, 7 months ago (2016-05-20 00:41:24 UTC) #5
jeffbrown
4 years, 7 months ago (2016-05-20 20:18:24 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
78a7acc47ef8fb9e26ac3137d8b53b61fba0a289 (presubmit successful).

Powered by Google App Engine