Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1994043002: Get rid of a redundant function alias lastPositionInNode() (Closed)

Created:
4 years, 7 months ago by yosin_UTC9
Modified:
4 years, 7 months ago
Reviewers:
yoichio
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of a redundant function alias lastPositionInNode() This patch gets rid of a redundant function alias |lastPositionInNode()| by replacing it by its implementation |Position::lastPositionInNode()| to reduce call depth for ease of debugging and improving code health. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/f0145d429f3950ea3e34088d5d600543af2adbc9 Cr-Commit-Position: refs/heads/master@{#394724}

Patch Set 1 : 2016-05-19T14:50:30 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -23 lines) Patch
M third_party/WebKit/Source/core/editing/Position.h View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SurroundingText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
yoichio
lgtm
4 years, 7 months ago (2016-05-19 06:13:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994043002/1
4 years, 7 months ago (2016-05-19 06:35:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 09:49:34 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 09:50:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0145d429f3950ea3e34088d5d600543af2adbc9
Cr-Commit-Position: refs/heads/master@{#394724}

Powered by Google App Engine
This is Rietveld 408576698