third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp - Issue 1994043002: Get rid of a redundant function alias lastPositionInNode()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

Issue 1994043002: Get rid of a redundant function alias lastPositionInNode() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2016-05-19T14:50:30 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

index 99e7fa1c01ed7fd1856ed73c3c8ec03bb662e96a..54d7988128edcbc881b95fe9172027d6e75279fb 100644

--- a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

@@ -572,7 +572,7 @@ void ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline(Insert

// FIXME: Tolerate differences in id, class, and style attributes.

if (element->parentNode() && isNonTableCellHTMLBlockElement(element) && areIdenticalElements(*element, *element->parentNode())

&& VisiblePosition::firstPositionInNode(element->parentNode()).deepEquivalent() == VisiblePosition::firstPositionInNode(element).deepEquivalent()

- && createVisiblePosition(lastPositionInNode(element->parentNode())).deepEquivalent() == createVisiblePosition(lastPositionInNode(element)).deepEquivalent()) {

+ && createVisiblePosition(Position::lastPositionInNode(element->parentNode())).deepEquivalent() == createVisiblePosition(Position::lastPositionInNode(element)).deepEquivalent()) {

insertedNodes.willRemoveNodePreservingChildren(*element);

removeNodePreservingChildren(element, editingState);

if (editingState->isAborted())

@@ -705,7 +705,7 @@ void ReplaceSelectionCommand::moveElementOutOfAncestor(Element* element, Element

return;

VisiblePosition positionAtEndOfNode = createVisiblePosition(lastPositionInOrAfterNode(element));

- VisiblePosition lastPositionInParagraph = createVisiblePosition(lastPositionInNode(ancestor));

+ VisiblePosition lastPositionInParagraph = createVisiblePosition(Position::lastPositionInNode(ancestor));

if (positionAtEndOfNode.deepEquivalent() == lastPositionInParagraph.deepEquivalent()) {

removeNode(element, editingState);

if (editingState->isAborted())