third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp - Issue 1994043002: Get rid of a redundant function alias lastPositionInNode()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

Issue 1994043002: Get rid of a redundant function alias lastPositionInNode() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2016-05-19T14:50:30 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

index e9d3da566ec5c8e55f278103b4c6a6be96bfc09b..cf4bcaafc31078a90dd816cf396a9074da2e9d74 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

@@ -281,7 +281,7 @@ bool InsertListCommand::doApplyForSingleParagraph(bool forceCreateList, const HT

Node* firstChildInList = enclosingListChild(VisiblePosition::firstPositionInNode(listElement).deepEquivalent().anchorNode(), listElement);

Element* outerBlock = firstChildInList && isBlockFlowElement(*firstChildInList) ? toElement(firstChildInList) : listElement;

- moveParagraphWithClones(VisiblePosition::firstPositionInNode(listElement), createVisiblePosition(lastPositionInNode(listElement)), newList, outerBlock, editingState);

+ moveParagraphWithClones(VisiblePosition::firstPositionInNode(listElement), createVisiblePosition(Position::lastPositionInNode(listElement)), newList, outerBlock, editingState);

if (editingState->isAborted())

return false;

@@ -333,7 +333,7 @@ void InsertListCommand::unlistifyParagraph(const VisiblePosition& originalStart,

DCHECK(listChildNode);

if (isHTMLLIElement(*listChildNode)) {

start = VisiblePosition::firstPositionInNode(listChildNode);

- end = createVisiblePosition(lastPositionInNode(listChildNode));

+ end = createVisiblePosition(Position::lastPositionInNode(listChildNode));

nextListChild = listChildNode->nextSibling();

previousListChild = listChildNode->previousSibling();

} else {