third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp - Issue 1994043002: Get rid of a redundant function alias lastPositionInNode()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

Issue 1994043002: Get rid of a redundant function alias lastPositionInNode() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2016-05-19T14:50:30 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

index 9721189a3ba80ad3068408d00fab9cbf11808884..4fde7681215c23c4264f215b86c8f50714e9ac28 100644

--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

@@ -518,7 +518,7 @@ void SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar(Node* node, const Ep

TRACE_EVENT0("blink", "SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar");

if (!node)

return;

- EphemeralRange paragraphRange(Position::firstPositionInNode(node), lastPositionInNode(node));

+ EphemeralRange paragraphRange(Position::firstPositionInNode(node), Position::lastPositionInNode(node));

TextCheckingParagraph textToCheck(insertedRange, paragraphRange);

chunkAndMarkAllMisspellingsAndBadGrammar(resolveTextCheckingTypeMask(TextCheckingTypeSpelling | TextCheckingTypeGrammar), textToCheck);

}

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp ('k') | no next file » | no next file with comments »