third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp - Issue 1994043002: Get rid of a redundant function alias lastPositionInNode()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

Issue 1994043002: Get rid of a redundant function alias lastPositionInNode() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2016-05-19T14:50:30 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

index 05a15dd50726c3f953f2a8be9709ad34098998dc..5629a3f835bea23d328b09e5b2e2518773f2ed48 100644

--- a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

@@ -49,7 +49,7 @@ using namespace HTMLNames;

static bool isTableCellEmpty(Node* cell)

{

DCHECK(isTableCell(cell)) << cell;

- return VisiblePosition::firstPositionInNode(cell).deepEquivalent() == createVisiblePosition(lastPositionInNode(cell)).deepEquivalent();

+ return VisiblePosition::firstPositionInNode(cell).deepEquivalent() == createVisiblePosition(Position::lastPositionInNode(cell)).deepEquivalent();

}

static bool isTableRowEmpty(Node* row)

@@ -399,7 +399,7 @@ void DeleteSelectionCommand::removeNode(Node* node, EditingState* editingState,

m_needPlaceholder = true;

}

if (node == m_endBlock) {

- VisiblePosition next = nextPositionOf(createVisiblePosition(lastPositionInNode(m_endBlock.get())));

+ VisiblePosition next = nextPositionOf(createVisiblePosition(Position::lastPositionInNode(m_endBlock.get())));

if (next.isNotNull() && !isStartOfBlock(next))

m_needPlaceholder = true;

}