third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp - Issue 1994043002: Get rid of a redundant function alias lastPositionInNode()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

Issue 1994043002: Get rid of a redundant function alias lastPositionInNode() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2016-05-19T14:50:30 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

index 09c3a54af7f882473c557d24bf4aa287382e1d8d..9b2cb8fa2022001246d8b073dbe254e43d5e46ce 100644

--- a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

@@ -1541,7 +1541,7 @@ Position CompositeEditCommand::positionAvoidingSpecialElementBoundary(const Posi

// Don't avoid block level anchors, because that would insert content into the wrong paragraph.

if (enclosingAnchor && !isEnclosingBlock(enclosingAnchor)) {

VisiblePosition firstInAnchor = VisiblePosition::firstPositionInNode(enclosingAnchor);

- VisiblePosition lastInAnchor = createVisiblePosition(lastPositionInNode(enclosingAnchor));

+ VisiblePosition lastInAnchor = createVisiblePosition(Position::lastPositionInNode(enclosingAnchor));

// If visually just after the anchor, insert *inside* the anchor unless it's the last

// VisiblePosition in the document, to match NSTextView.

if (visiblePos.deepEquivalent() == lastInAnchor.deepEquivalent()) {