third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp - Issue 1994043002: Get rid of a redundant function alias lastPositionInNode()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

Issue 1994043002: Get rid of a redundant function alias lastPositionInNode() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2016-05-19T14:50:30 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp ('k') | third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp b/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

index d39bb31791fd4e25f9a7685fc43f865a4a9bfbd0..8fe2ffebce41d8288ffa0c75f823daaf0dd5846e 100644

--- a/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

@@ -612,7 +612,7 @@ void TypingCommand::forwardDeleteKeyPressed(TextGranularity granularity, bool ki

Position downstreamEnd = mostForwardCaretPosition(endingSelection().end());

VisiblePosition visibleEnd = endingSelection().visibleEnd();

Node* enclosingTableCell = enclosingNodeOfType(visibleEnd.deepEquivalent(), &isTableCell);

- if (enclosingTableCell && visibleEnd.deepEquivalent() == createVisiblePosition(lastPositionInNode(enclosingTableCell)).deepEquivalent())

+ if (enclosingTableCell && visibleEnd.deepEquivalent() == createVisiblePosition(Position::lastPositionInNode(enclosingTableCell)).deepEquivalent())

return;

if (visibleEnd.deepEquivalent() == endOfParagraph(visibleEnd).deepEquivalent())

downstreamEnd = mostForwardCaretPosition(nextPositionOf(visibleEnd, CannotCrossEditingBoundary).deepEquivalent());