Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 197763008: Allow toString capability to be toggled independent of developer mode (Closed)

Created:
6 years, 9 months ago by robertphillips
Modified:
6 years, 9 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Allow toString capability to be toggled independent of developer mode. This change is motivated by the desire to see the text information in the debugger when not in developer mode. It is structured so user's can disable it if the capability is not wanted. Committed: http://code.google.com/p/skia/source/detail?r=13795

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : remove gyp changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -98 lines) Patch
M include/core/SkBitmap.h View 1 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkColorFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkColorShader.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkComposeShader.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkDrawLooper.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkEmptyShader.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkMaskFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkMatrix.h View 1 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkPaint.h View 1 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkShader.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M include/core/SkTypes.h View 1 1 chunk +14 lines, -4 lines 0 comments Download
M include/core/SkXfermode.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M include/effects/SkAvoidXfermode.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkBlurDrawLooper.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkColorMatrixFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkEmbossMaskFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkKernel33MaskFilter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/effects/SkLayerDrawLooper.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkLerpXfermode.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkLumaColorFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkPerlinNoiseShader.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkPixelXorXfermode.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkStippleMaskFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkTableMaskFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkTransparentShader.h View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleText.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkBitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapProcShader.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapProcShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBlitter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkComposeShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkDraw.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkFilterShader.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkFilterShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkMatrix.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkPaint.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/core/SkShader.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkXfermode.cpp View 10 chunks +10 lines, -10 lines 0 comments Download
M src/core/SkXfermode_proccoeff.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkArithmeticMode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkAvoidXfermode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlurDrawLooper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkEmbossMaskFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkKernel33MaskFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkLayerDrawLooper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkLerpXfermode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkPixelXorXfermode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkStippleMaskFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkTableColorFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkTableMaskFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkTransparentShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkRadialGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkSweepGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/opts/SkXfermode_opts_arm_neon.h View 1 chunk +1 line, -1 line 0 comments Download
M src/opts/SkXfermode_opts_arm_neon.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/debugger/SkObjectParser.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/QuickRejectTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
6 years, 9 months ago (2014-03-13 16:36:08 UTC) #1
bsalomon
lgtm
6 years, 9 months ago (2014-03-13 16:41:55 UTC) #2
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 9 months ago (2014-03-13 16:56:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/197763008/40001
6 years, 9 months ago (2014-03-13 16:56:47 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 18:02:41 UTC) #5
Message was sent while issue was closed.
Change committed as 13795

Powered by Google App Engine
This is Rietveld 408576698