Reduce the site engagement service public interface.

Reduce the site engagement service public interface.

This CL cleans up the site engagement service in two main ways.
SiteEngagementScore is now in its own header, implementation,
and test files, which moves nearly 1000 lines of code out of the
SiteEngagementService files. The SiteEngagementHelper is now
a public inner class of SiteEngagementService, which means
several public methods in SiteEngagementService can be made
private, cleaning up its public interface.

BUG=610943
TBR=tedchoc@chromium.org,avi@chromium.org,dbeam@chromium.org,peter@chromium.org,benwells@chromium.org

Committed: https://crrev.com/9d7502c4ce21d3441806c30817449305a0198ec7
Cr-Commit-Position: refs/heads/master@{#393800}

[dominickn, 2016-05-12 08:40:53]

Description was changed from

==========
Clean up the site engagement service.

 - Move SiteEngagementScore into its own header and cc file
 - Make SiteEngagementHelper a public inner class of
   SiteEngagementService. This means that several public methods in
   SiteEngagementService can now become private, cleaning up its public
   interface.

BUG=610943
==========

to

==========
Reduce the public interface of the site engagement service.

 - Move SiteEngagementScore into its own header and cc file
 - Make SiteEngagementHelper a public inner class of
   SiteEngagementService. This means that several public methods in
   SiteEngagementService can now become private, cleaning up its public
   interface.

BUG=610943
==========

[dominickn, 2016-05-12 08:40:53]

dominickn@chromium.org changed reviewers:
+ calamity@chromium.org

[dominickn, 2016-05-12 23:17:55]

Description was changed from

==========
Reduce the public interface of the site engagement service.

 - Move SiteEngagementScore into its own header and cc file
 - Make SiteEngagementHelper a public inner class of
   SiteEngagementService. This means that several public methods in
   SiteEngagementService can now become private, cleaning up its public
   interface.

BUG=610943
==========

to

==========
Reduce the site engagement service public interface.

 - Move SiteEngagementScore into its own header and cc file
 - Make SiteEngagementHelper a public inner class of
   SiteEngagementService. This means that several public methods in
   SiteEngagementService can now become private, cleaning up its public
   interface.

BUG=610943
==========

[dominickn, 2016-05-13 01:38:24]

Description was changed from

==========
Reduce the site engagement service public interface.

 - Move SiteEngagementScore into its own header and cc file
 - Make SiteEngagementHelper a public inner class of
   SiteEngagementService. This means that several public methods in
   SiteEngagementService can now become private, cleaning up its public
   interface.

BUG=610943
==========

to

==========
Reduce the site engagement service public interface.

This CL cleans up the site engagement service in two main ways.
SiteEngagementScore is now in its own header, implementation,
and test files, which moves nearly 1000 lines of code out of the
SiteEngagementService files. The SiteEngagementHelper is now
a public inner class of SiteEngagementService, which means 
several public methods in SiteEngagementService can be made
private, cleaning up its public interface.

BUG=610943
==========

[dominickn, 2016-05-13 02:12:35]

PTAL, thanks!

[calamity, 2016-05-16 04:35:49]

Awesome! lgtm.

https://codereview.chromium.org/1975723002/diff/60001/chrome/browser/engageme...
File chrome/browser/engagement/site_engagement_service.h (right):

https://codereview.chromium.org/1975723002/diff/60001/chrome/browser/engageme...
chrome/browser/engagement/site_engagement_service.h:57: //  WebContentsObserver
that detects engagement triggering events and notifies
nit: double space at line-start

[dominickn, 2016-05-16 04:45:01]

Description was changed from

==========
Reduce the site engagement service public interface.

This CL cleans up the site engagement service in two main ways.
SiteEngagementScore is now in its own header, implementation,
and test files, which moves nearly 1000 lines of code out of the
SiteEngagementService files. The SiteEngagementHelper is now
a public inner class of SiteEngagementService, which means 
several public methods in SiteEngagementService can be made
private, cleaning up its public interface.

BUG=610943
==========

to

==========
Reduce the site engagement service public interface.

This CL cleans up the site engagement service in two main ways.
SiteEngagementScore is now in its own header, implementation,
and test files, which moves nearly 1000 lines of code out of the
SiteEngagementService files. The SiteEngagementHelper is now
a public inner class of SiteEngagementService, which means 
several public methods in SiteEngagementService can be made
private, cleaning up its public interface.

BUG=610943
TBR=tedchoc,avi,dbeam
==========

[dominickn, 2016-05-16 04:45:54]

Description was changed from

==========
Reduce the site engagement service public interface.

This CL cleans up the site engagement service in two main ways.
SiteEngagementScore is now in its own header, implementation,
and test files, which moves nearly 1000 lines of code out of the
SiteEngagementService files. The SiteEngagementHelper is now
a public inner class of SiteEngagementService, which means 
several public methods in SiteEngagementService can be made
private, cleaning up its public interface.

BUG=610943
TBR=tedchoc,avi,dbeam
==========

to

==========
Reduce the site engagement service public interface.

This CL cleans up the site engagement service in two main ways.
SiteEngagementScore is now in its own header, implementation,
and test files, which moves nearly 1000 lines of code out of the
SiteEngagementService files. The SiteEngagementHelper is now
a public inner class of SiteEngagementService, which means 
several public methods in SiteEngagementService can be made
private, cleaning up its public interface.

BUG=610943
TBR=tedchoc@chromium.org,avi@chromium.org,dbeam@chromium.org
==========

[dominickn, 2016-05-16 04:53:06]

Thanks! I will TBR the other owners as this is a purely refactoring/API change.
The only thing changing in non site engagement files are includes or the names
of function calls.

https://codereview.chromium.org/1975723002/diff/60001/chrome/browser/engageme...
File chrome/browser/engagement/site_engagement_service.h (right):

https://codereview.chromium.org/1975723002/diff/60001/chrome/browser/engageme...
chrome/browser/engagement/site_engagement_service.h:57: //  WebContentsObserver
that detects engagement triggering events and notifies
On 2016/05/16 04:35:49, calamity wrote:
> nit: double space at line-start

Done.

[dominickn, 2016-05-16 05:16:26]

Description was changed from

==========
Reduce the site engagement service public interface.

This CL cleans up the site engagement service in two main ways.
SiteEngagementScore is now in its own header, implementation,
and test files, which moves nearly 1000 lines of code out of the
SiteEngagementService files. The SiteEngagementHelper is now
a public inner class of SiteEngagementService, which means 
several public methods in SiteEngagementService can be made
private, cleaning up its public interface.

BUG=610943
TBR=tedchoc@chromium.org,avi@chromium.org,dbeam@chromium.org
==========

to

==========
Reduce the site engagement service public interface.

This CL cleans up the site engagement service in two main ways.
SiteEngagementScore is now in its own header, implementation,
and test files, which moves nearly 1000 lines of code out of the
SiteEngagementService files. The SiteEngagementHelper is now
a public inner class of SiteEngagementService, which means 
several public methods in SiteEngagementService can be made
private, cleaning up its public interface.

BUG=610943
TBR=tedchoc@chromium.org,avi@chromium.org,dbeam@chromium.org,peter@chromium.org
==========

[dominickn, 2016-05-16 05:47:11]

Description was changed from

==========
Reduce the site engagement service public interface.

This CL cleans up the site engagement service in two main ways.
SiteEngagementScore is now in its own header, implementation,
and test files, which moves nearly 1000 lines of code out of the
SiteEngagementService files. The SiteEngagementHelper is now
a public inner class of SiteEngagementService, which means 
several public methods in SiteEngagementService can be made
private, cleaning up its public interface.

BUG=610943
TBR=tedchoc@chromium.org,avi@chromium.org,dbeam@chromium.org,peter@chromium.org
==========

to

==========
Reduce the site engagement service public interface.

This CL cleans up the site engagement service in two main ways.
SiteEngagementScore is now in its own header, implementation,
and test files, which moves nearly 1000 lines of code out of the
SiteEngagementService files. The SiteEngagementHelper is now
a public inner class of SiteEngagementService, which means 
several public methods in SiteEngagementService can be made
private, cleaning up its public interface.

BUG=610943
TBR=tedchoc@chromium.org,avi@chromium.org,dbeam@chromium.org,peter@chromium.o...
==========

[dominickn, 2016-05-16 07:01:29]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2016-05-16 07:01:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/1975723002/#ps100001
(title: "Push messaging now uses engagement")

[commit-bot: I haz the power, 2016-05-16 07:01:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1975723002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1975723002/100001

[commit-bot: I haz the power, 2016-05-16 07:09:27]

Description was changed from

==========
Reduce the site engagement service public interface.

This CL cleans up the site engagement service in two main ways.
SiteEngagementScore is now in its own header, implementation,
and test files, which moves nearly 1000 lines of code out of the
SiteEngagementService files. The SiteEngagementHelper is now
a public inner class of SiteEngagementService, which means 
several public methods in SiteEngagementService can be made
private, cleaning up its public interface.

BUG=610943
TBR=tedchoc@chromium.org,avi@chromium.org,dbeam@chromium.org,peter@chromium.o...
==========

to

==========
Reduce the site engagement service public interface.

This CL cleans up the site engagement service in two main ways.
SiteEngagementScore is now in its own header, implementation,
and test files, which moves nearly 1000 lines of code out of the
SiteEngagementService files. The SiteEngagementHelper is now
a public inner class of SiteEngagementService, which means 
several public methods in SiteEngagementService can be made
private, cleaning up its public interface.

BUG=610943
TBR=tedchoc@chromium.org,avi@chromium.org,dbeam@chromium.org,peter@chromium.o...
==========

[commit-bot: I haz the power, 2016-05-16 07:09:28]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-16 07:10:21]

Description was changed from

==========
Reduce the site engagement service public interface.

This CL cleans up the site engagement service in two main ways.
SiteEngagementScore is now in its own header, implementation,
and test files, which moves nearly 1000 lines of code out of the
SiteEngagementService files. The SiteEngagementHelper is now
a public inner class of SiteEngagementService, which means 
several public methods in SiteEngagementService can be made
private, cleaning up its public interface.

BUG=610943
TBR=tedchoc@chromium.org,avi@chromium.org,dbeam@chromium.org,peter@chromium.o...
==========

to

==========
Reduce the site engagement service public interface.

This CL cleans up the site engagement service in two main ways.
SiteEngagementScore is now in its own header, implementation,
and test files, which moves nearly 1000 lines of code out of the
SiteEngagementService files. The SiteEngagementHelper is now
a public inner class of SiteEngagementService, which means
several public methods in SiteEngagementService can be made
private, cleaning up its public interface.

BUG=610943
TBR=tedchoc@chromium.org,avi@chromium.org,dbeam@chromium.org,peter@chromium.o...

Committed: https://crrev.com/9d7502c4ce21d3441806c30817449305a0198ec7
Cr-Commit-Position: refs/heads/master@{#393800}
==========

[commit-bot: I haz the power, 2016-05-16 07:10:22]

Patchset 6 (id:??) landed as
https://crrev.com/9d7502c4ce21d3441806c30817449305a0198ec7
Cr-Commit-Position: refs/heads/master@{#393800}