chrome/browser/ui/webui/engagement/site_engagement_ui.cc - Issue 1975723002: Reduce the site engagement service public interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/engagement/site_engagement_ui.cc

Issue 1975723002: Reduce the site engagement service public interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Push messaging now uses engagement Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/engagement/site_engagement_ui.cc

diff --git a/chrome/browser/ui/webui/engagement/site_engagement_ui.cc b/chrome/browser/ui/webui/engagement/site_engagement_ui.cc

index 1413222c9f7526c43cf7f6bab29557d65927e055..1a24feda036871181a4e42e14d59a7c28269ea12 100644

--- a/chrome/browser/ui/webui/engagement/site_engagement_ui.cc

+++ b/chrome/browser/ui/webui/engagement/site_engagement_ui.cc

@@ -57,7 +57,7 @@ class SiteEngagementUIHandlerImpl : public mojom::SiteEngagementUIHandler {

double score) override {

GURL origin_gurl(origin.get());

if (!origin_gurl.is_valid() || score < 0 ||

- score > SiteEngagementScore::kMaxPoints || std::isnan(score)) {

+ score > SiteEngagementService::GetMaxPoints() || std::isnan(score)) {

return;

}

« no previous file with comments | « chrome/browser/ui/tab_helpers.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »