Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: chrome/browser/banners/app_banner_settings_helper_unittest.cc

Issue 1975723002: Reduce the site engagement service public interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Push messaging now uses engagement Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "chrome/browser/banners/app_banner_metrics.h" 8 #include "chrome/browser/banners/app_banner_metrics.h"
9 #include "chrome/browser/banners/app_banner_settings_helper.h" 9 #include "chrome/browser/banners/app_banner_settings_helper.h"
10 #include "chrome/browser/engagement/site_engagement_service.h" 10 #include "chrome/browser/engagement/site_engagement_service.h"
11 #include "chrome/browser/engagement/site_engagement_service_factory.h"
12 #include "chrome/common/chrome_switches.h" 11 #include "chrome/common/chrome_switches.h"
13 #include "chrome/test/base/chrome_render_view_host_test_harness.h" 12 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
14 #include "chrome/test/base/testing_profile.h" 13 #include "chrome/test/base/testing_profile.h"
15 #include "ui/base/page_transition_types.h" 14 #include "ui/base/page_transition_types.h"
16 15
17 namespace { 16 namespace {
18 17
19 const char kTestURL[] = "https://www.google.com"; 18 const char kTestURL[] = "https://www.google.com";
20 const char kSameOriginTestURL[] = "https://www.google.com/foo.html"; 19 const char kSameOriginTestURL[] = "https://www.google.com/foo.html";
21 const char kTestPackageName[] = "test.package"; 20 const char kTestPackageName[] = "test.package";
(...skipping 754 matching lines...) Expand 10 before | Expand all | Expand 10 after
776 ui::PAGE_TRANSITION_TYPED); 775 ui::PAGE_TRANSITION_TYPED);
777 EXPECT_TRUE(AppBannerSettingsHelper::ShouldShowBanner( 776 EXPECT_TRUE(AppBannerSettingsHelper::ShouldShowBanner(
778 web_contents(), url, kTestPackageName, fifth_day)); 777 web_contents(), url, kTestPackageName, fifth_day));
779 } 778 }
780 779
781 // Test that the banner triggers correctly using site engagement. 780 // Test that the banner triggers correctly using site engagement.
782 TEST_F(AppBannerSettingsHelperTest, SiteEngagementTrigger) { 781 TEST_F(AppBannerSettingsHelperTest, SiteEngagementTrigger) {
783 base::CommandLine* command_line = base::CommandLine::ForCurrentProcess(); 782 base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
784 command_line->AppendSwitch(switches::kEnableSiteEngagementAppBanner); 783 command_line->AppendSwitch(switches::kEnableSiteEngagementAppBanner);
785 784
786 SiteEngagementService* service = 785 SiteEngagementService* service = SiteEngagementService::Get(profile());
787 SiteEngagementServiceFactory::GetForProfile(profile());
788 DCHECK(service); 786 DCHECK(service);
789 787
790 // Not used, but needed for method call. 788 // Not used, but needed for method call.
791 base::Time reference_time = GetReferenceTime(); 789 base::Time reference_time = GetReferenceTime();
792 GURL url(kTestURL); 790 GURL url(kTestURL);
793 791
794 EXPECT_FALSE(AppBannerSettingsHelper::ShouldShowBanner( 792 EXPECT_FALSE(AppBannerSettingsHelper::ShouldShowBanner(
795 web_contents(), url, kTestPackageName, reference_time)); 793 web_contents(), url, kTestPackageName, reference_time));
796 794
797 service->AddPoints(url, 1); 795 service->AddPoints(url, 1);
(...skipping 13 matching lines...) Expand all
811 web_contents(), url, kTestPackageName, reference_time)); 809 web_contents(), url, kTestPackageName, reference_time));
812 810
813 service->AddPoints(url, 0.5); 811 service->AddPoints(url, 0.5);
814 EXPECT_FALSE(AppBannerSettingsHelper::ShouldShowBanner( 812 EXPECT_FALSE(AppBannerSettingsHelper::ShouldShowBanner(
815 web_contents(), url, kTestPackageName, reference_time)); 813 web_contents(), url, kTestPackageName, reference_time));
816 814
817 service->AddPoints(url, 1.5); 815 service->AddPoints(url, 1.5);
818 EXPECT_TRUE(AppBannerSettingsHelper::ShouldShowBanner( 816 EXPECT_TRUE(AppBannerSettingsHelper::ShouldShowBanner(
819 web_contents(), url, kTestPackageName, reference_time)); 817 web_contents(), url, kTestPackageName, reference_time));
820 } 818 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698