chrome/browser/banners/app_banner_settings_helper_unittest.cc - Issue 1975723002: Reduce the site engagement service public interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_settings_helper_unittest.cc

Issue 1975723002: Reduce the site engagement service public interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Push messaging now uses engagement Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/preferences/important_sites_util_unittest.cc ('k') | chrome/browser/engagement/site_engagement_eviction_policy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/banners/app_banner_settings_helper_unittest.cc

diff --git a/chrome/browser/banners/app_banner_settings_helper_unittest.cc b/chrome/browser/banners/app_banner_settings_helper_unittest.cc

index 1c8d10bafc76fc00d59d06d81b31368a2a25ae9f..5a4b8029e913a51ea297b1f3b364828cf7c2c8e5 100644

--- a/chrome/browser/banners/app_banner_settings_helper_unittest.cc

+++ b/chrome/browser/banners/app_banner_settings_helper_unittest.cc

@@ -8,7 +8,6 @@

#include "chrome/browser/banners/app_banner_metrics.h"

#include "chrome/browser/banners/app_banner_settings_helper.h"

#include "chrome/browser/engagement/site_engagement_service.h"

-#include "chrome/browser/engagement/site_engagement_service_factory.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/test/base/chrome_render_view_host_test_harness.h"

#include "chrome/test/base/testing_profile.h"

@@ -783,8 +782,7 @@ TEST_F(AppBannerSettingsHelperTest, SiteEngagementTrigger) {

base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();

command_line->AppendSwitch(switches::kEnableSiteEngagementAppBanner);

- SiteEngagementService* service =

- SiteEngagementServiceFactory::GetForProfile(profile());

+ SiteEngagementService* service = SiteEngagementService::Get(profile());

DCHECK(service);

// Not used, but needed for method call.