chrome/browser/ui/tab_helpers.cc - Issue 1975723002: Reduce the site engagement service public interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_helpers.cc

Issue 1975723002: Reduce the site engagement service public interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Push messaging now uses engagement Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/push_messaging/background_budget_service.cc ('k') | chrome/browser/ui/webui/engagement/site_engagement_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/tab_helpers.cc

diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc

index 2c8de2f0ba864d4d4dce02bad77ce44ec2b6377c..6398c772a5fea2f5465fd2424738fc9511f2201e 100644

--- a/chrome/browser/ui/tab_helpers.cc

+++ b/chrome/browser/ui/tab_helpers.cc

@@ -172,7 +172,7 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {

SearchTabHelper::CreateForWebContents(web_contents);

ChromeSecurityStateModelClient::CreateForWebContents(web_contents);

if (SiteEngagementService::IsEnabled())

- SiteEngagementHelper::CreateForWebContents(web_contents);

+ SiteEngagementService::Helper::CreateForWebContents(web_contents);

// TODO(vabr): Remove TabSpecificContentSettings from here once their function

// is taken over by ChromeContentSettingsClient. http://crbug.com/387075

TabSpecificContentSettings::CreateForWebContents(web_contents);