chrome/browser/engagement/site_engagement_eviction_policy.cc - Issue 1975723002: Reduce the site engagement service public interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_eviction_policy.cc

Issue 1975723002: Reduce the site engagement service public interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Push messaging now uses engagement Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/banners/app_banner_settings_helper_unittest.cc ('k') | chrome/browser/engagement/site_engagement_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/engagement/site_engagement_eviction_policy.cc

diff --git a/chrome/browser/engagement/site_engagement_eviction_policy.cc b/chrome/browser/engagement/site_engagement_eviction_policy.cc

index 314500ceee8b7eb07a82ac2cd4eb4081198c676f..869e072a09215fee27a28a5c6a9653c0cb8c44ef 100644

--- a/chrome/browser/engagement/site_engagement_eviction_policy.cc

+++ b/chrome/browser/engagement/site_engagement_eviction_policy.cc

@@ -25,7 +25,7 @@ int64_t GetSoftQuotaForOrigin(const GURL& origin,

int64_t global_quota) {

double quota_per_point =

global_quota /

- std::max(kExpectedEngagementSites * SiteEngagementScore::kMaxPoints,

+ std::max(kExpectedEngagementSites * SiteEngagementService::GetMaxPoints(),

static_cast<double>(total_engagement_points));

return score * quota_per_point;