Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1967393002: [DO NOT SUBMIT] AudioWorklet FS2: audio thread (Closed)

Created:
4 years, 7 months ago by hongchan
Modified:
4 years, 3 months ago
Reviewers:
CC:
Raymond Toy, ikilpatrick
Base URL:
https://chromium.googlesource.com/chromium/src.git@FS1-audioworklet-script-importing
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AudioWorklet FS2 - AudioRenderSink/Destination Refactor - AudioWorkletThread - AudioWorkletThreadSharedState (V8 + WebThread)

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+342 lines, -152 lines) Patch
M third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.h View 2 chunks +20 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.cpp View 2 chunks +21 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioWorkletProcessorDefinition.cpp View 2 chunks +0 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.cpp View 3 chunks +30 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp View 2 chunks +11 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioIOCallback.h View 1 chunk +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioPullFIFO.h View 1 chunk +33 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioPullFIFO.cpp View 2 chunks +13 lines, -16 lines 0 comments Download
A third_party/WebKit/Source/platform/audio/AudioRenderSink.h View 1 chunk +79 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/audio/AudioRenderSink.cpp View 1 chunk +119 lines, -0 lines 1 comment Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1960533003 Patch 1

Dependent Patchsets:

Issue 1978063002 Patch 1

Messages

Total messages: 4 (2 generated)
o1ka
https://codereview.chromium.org/1967393002/diff/1/third_party/WebKit/Source/platform/audio/AudioRenderSink.cpp File third_party/WebKit/Source/platform/audio/AudioRenderSink.cpp (right): https://codereview.chromium.org/1967393002/diff/1/third_party/WebKit/Source/platform/audio/AudioRenderSink.cpp#newcode70 third_party/WebKit/Source/platform/audio/AudioRenderSink.cpp:70: return static_cast<unsigned>(Platform::current()->audioHardwareOutputChannels()); If WebAudioDevice provides all these information, can ...
4 years, 6 months ago (2016-05-27 14:28:23 UTC) #3
hongchan
4 years, 6 months ago (2016-05-27 16:58:35 UTC) #4 
On 2016/05/27 14:28:23, o1ka wrote:
>
https://codereview.chromium.org/1967393002/diff/1/third_party/WebKit/Source/p...
> File third_party/WebKit/Source/platform/audio/AudioRenderSink.cpp (right):
> 
>
https://codereview.chromium.org/1967393002/diff/1/third_party/WebKit/Source/p...
> third_party/WebKit/Source/platform/audio/AudioRenderSink.cpp:70: return
> static_cast<unsigned>(Platform::current()->audioHardwareOutputChannels());
> If WebAudioDevice provides all these information, can it be used to return all
> those hardware values instead of accessing Platform::current()?

Yeap, then we need to fix RendererWebAudioDeviceImpl accordingly. A simple
change, but a better design.

Powered by Google App Engine
This is Rietveld 408576698