Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioWorkletProcessorDefinition.cpp

Issue 1967393002: [DO NOT SUBMIT] AudioWorklet FS2: audio thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@FS1-audioworklet-script-importing
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioWorkletProcessorDefinition.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioWorkletProcessorDefinition.cpp b/third_party/WebKit/Source/modules/webaudio/AudioWorkletProcessorDefinition.cpp
index ceef16e0daca99e4afc8766e2fafcffc70755975..350784504a8d2f591623c97c33ad8db01cb54687 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioWorkletProcessorDefinition.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/AudioWorkletProcessorDefinition.cpp
@@ -32,35 +32,6 @@ void AudioWorkletProcessorDefinition::process()
{
// TODO: currently this happens in the main thread!!!
- // ScriptState::Scope scope(m_scriptState.get());
-
- // maybeCreateProcessInstance();
-
- // v8::Isolate* isolate = m_scriptState->isolate();
-
- // We may have failed to create an instance class, in which case produce an
- // invalid image.
- // if (isUndefinedOrNull(instance))
- // return nullptr;
-
- // TODO: do some audio stuff.
- // v8::Local<v8::Value> argv[] = {
- // toV8(someAudioStuff, m_scriptState->context()->Global(), isolate),
- // };
-
- // v8::Local<v8::Function> process = m_process.newLocal(isolate);
-
- // v8::TryCatch block(isolate);
- // block.SetVerbose(true);
-
- // V8ScriptRunner::callFunction(process, m_scriptState->getExecutionContext(), instance, 2, argv, isolate);
-
- // The paint function may have produced an error, in which case produce an
- // invalid image.
- // if (block.HasCaught()) {
- // return;
- // }
-
return;
}
@@ -69,17 +40,6 @@ void AudioWorkletProcessorDefinition::maybeCreateProcessInstance()
if (m_didCallConstructor)
return;
- // DCHECK(m_instance.isEmpty());
-
- // v8::Isolate* isolate = m_scriptState->isolate();
- // v8::Local<v8::Function> constructor = m_constructor.newLocal(isolate);
- // DCHECK(!isUndefinedOrNull(constructor));
-
- // v8::Local<v8::Object> processInstance;
- // if (V8ObjectConstructor::newInstance(isolate, constructor).ToLocal(&processInstance)) {
- // m_instance.set(isolate, processInstance);
- // }
-
m_didCallConstructor = true;
}

Powered by Google App Engine
This is Rietveld 408576698