Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1978063002: [DO NOT SUBMIT] AudioWorklet FS2a: AudioWorkletThread on OfflineAudioContext (Closed)

Created:
4 years, 7 months ago by hongchan
Modified:
4 years, 3 months ago
Reviewers:
CC:
Raymond Toy, ikilpatrick
Base URL:
https://chromium.googlesource.com/chromium/src.git@FS2-audiorendersink-audioworkletthread
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DO NOT SUBMIT] AudioWorklet FS2a: AudioWorkletThread on OfflineAudioContext - AudioWorkletThread - AudioWorkletThreadStartupData - OfflineAudioDestination Milestone 1: Passes layout tests

Patch Set 1 #

Total comments: 1

Messages

Total messages: 3 (2 generated)
hongchan
4 years, 7 months ago (2016-05-23 21:48:54 UTC) #3 
https://codereview.chromium.org/1978063002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webaudio/AudioWorkletThread.cpp (right):

https://codereview.chromium.org/1978063002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webaudio/AudioWorkletThread.cpp:189:
audioRenderThread().postTask(BLINK_FROM_HERE,
threadSafeBind(&AudioWorkletThread::initializeInternal,
AllowCrossThreadAccess(this), frame, passed(std::move(startupData))));
In file included from
../../third_party/WebKit/Source/modules/webaudio/AudioWorkletThread.cpp:5:
In file included from
../../third_party/WebKit/Source/modules/webaudio/AudioWorkletThread.h:9:
In file included from
../../third_party/WebKit/Source/platform/WebThreadSupportingGC.h:8:
In file included from
../../third_party/WebKit/Source/platform/heap/GCTaskRunner.h:34:
In file included from
../../third_party/WebKit/Source/platform/ThreadSafeFunctional.h:8:
../../third_party/WebKit/Source/platform/CrossThreadCopier.h:105:35: error:
implicit instantiation of undefined template
'blink::CrossThreadCopierBase<blink::LocalFrame *, false, false>'
struct CrossThreadCopier : public CrossThreadCopierBase<
                                  ^
../../third_party/WebKit/Source/platform/ThreadSafeFunctional.h:37:9: note: in
instantiation of template class 'blink::CrossThreadCopier<blink::LocalFrame *>'
requested here
        CrossThreadCopier<typename
std::decay<Ps>::type>::copy(std::forward<Ps>(parameters))...);
        ^
../../third_party/WebKit/Source/modules/webaudio/AudioWorkletThread.cpp:190:51:
note: in instantiation of function template specialization
'blink::threadSafeBind<, void (blink::AudioWorkletThread::*)(blink::LocalFrame
*, WTF::OwnPtr<blink::AudioWorkletThreadStartupData>),
blink::AllowCrossThreadAccessWrapper<blink::AudioWorkletThread *>,
blink::LocalFrame *&,
WTF::PassedWrapper<WTF::OwnPtr<blink::AudioWorkletThreadStartupData> > >'
requested here
    audioRenderThread().postTask(BLINK_FROM_HERE,
threadSafeBind(&AudioWorkletThread::initializeInternal,
AllowCrossThreadAccess(this), frame, passed(std::move(startupData))));
                                                  ^
../../third_party/WebKit/Source/platform/CrossThreadCopier.h:75:8: note:
template is declared here
struct CrossThreadCopierBase;
       ^
1 error generated.

Powered by Google App Engine
This is Rietveld 408576698