Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1933573002: [DevTools] Remove last bits of logic from v8 agent wrappers. (Closed)

Created:
4 years, 7 months ago by dgozman
Modified:
4 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@1913283003
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove last bits of logic from v8 agent wrappers. BUG=580337 Committed: https://crrev.com/33d87c95744c867b4ce166d01c30c69f83f23e71 Cr-Commit-Position: refs/heads/master@{#392753}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebased, fixed uninitialized variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -88 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.h View 2 chunks +1 line, -11 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp View 2 chunks +1 line, -11 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.h View 2 chunks +1 line, -9 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.cpp View 5 chunks +2 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.h View 2 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.cpp View 2 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageDebuggerAgent.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp View 2 chunks +1 line, -12 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageRuntimeAgent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.h View 2 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp View 2 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.h View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerRuntimeAgent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerRuntimeAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 1 2 3 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 2 chunks +9 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp View 2 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp View 1 2 3 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.h View 3 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 1 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 2 3 chunks +14 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
dgozman
Could you please take a look?
4 years, 7 months ago (2016-04-29 01:28:19 UTC) #2
pfeldman
lgtm
4 years, 7 months ago (2016-04-29 02:16:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933573002/20001
4 years, 7 months ago (2016-04-29 23:48:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/154636)
4 years, 7 months ago (2016-04-30 00:48:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933573002/40001
4 years, 7 months ago (2016-05-10 18:39:29 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-10 22:43:24 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 22:44:47 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/33d87c95744c867b4ce166d01c30c69f83f23e71
Cr-Commit-Position: refs/heads/master@{#392753}

Powered by Google App Engine
This is Rietveld 408576698