third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp - Issue 1933573002: [DevTools] Remove last bits of logic from v8 agent wrappers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp

Issue 1933573002: [DevTools] Remove last bits of logic from v8 agent wrappers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1913283003

Patch Set: rebased, fixed uninitialized variable Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/PageDebuggerAgent.h ('k') | third_party/WebKit/Source/core/inspector/PageRuntimeAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp b/third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp

index 56e3fab731b6e47c1e8293aa212bde27001a89a5..f07e0344ffca84eb9ce7f9a948841bd1d9b649a0 100644

--- a/third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp

@@ -66,18 +66,8 @@ DEFINE_TRACE(PageDebuggerAgent)

InspectorDebuggerAgent::trace(visitor);

}

-bool PageDebuggerAgent::canExecuteScripts() const

- ScriptController& scriptController = m_inspectedFrames->root()->script();

- return scriptController.canExecuteScripts(NotAboutToExecuteScript);

void PageDebuggerAgent::enable(ErrorString* errorString)

{

- if (!canExecuteScripts()) {

- *errorString = "Script execution is prohibited";

- return;

- }

InspectorDebuggerAgent::enable(errorString);

}

@@ -89,8 +79,7 @@ void PageDebuggerAgent::disable(ErrorString* errorString)

void PageDebuggerAgent::restore()

{

- if (canExecuteScripts())

- InspectorDebuggerAgent::restore();

+ InspectorDebuggerAgent::restore();

}