Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 1933573002: [DevTools] Remove last bits of logic from v8 agent wrappers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1913283003
Patch Set: rebased, fixed uninitialized variable Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebDevToolsAgentImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
index d07581392824bb16c12a89402dbf937c19592a01..21fcd9b1a31014aca7dfac5147cbefc130cfa6e5 100644
--- a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
+++ b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
@@ -384,7 +384,7 @@ void WebDevToolsAgentImpl::initializeSession(int sessionId, const String& hostId
v8::Isolate* isolate = V8PerIsolateData::mainThreadIsolate();
m_v8Session = mainThreadDebugger->debugger()->connect(mainThreadDebugger->contextGroupId(m_inspectedFrames->root()));
- m_session->append(PageRuntimeAgent::create(this, m_v8Session->runtimeAgent(), m_inspectedFrames.get()));
+ m_session->append(PageRuntimeAgent::create(m_v8Session->runtimeAgent(), m_inspectedFrames.get()));
InspectorDOMAgent* domAgent = new InspectorDOMAgent(isolate, m_inspectedFrames.get(), m_v8Session.get(), m_overlay.get());
m_domAgent = domAgent;
@@ -426,7 +426,7 @@ void WebDevToolsAgentImpl::initializeSession(int sessionId, const String& hostId
m_session->append(InspectorInputAgent::create(m_inspectedFrames.get()));
- m_session->append(InspectorProfilerAgent::create(m_v8Session->profilerAgent(), m_overlay.get()));
+ m_session->append(new InspectorProfilerAgent(m_v8Session->profilerAgent()));
m_session->append(InspectorHeapProfilerAgent::create(m_v8Session->heapProfilerAgent()));
@@ -611,6 +611,18 @@ void WebDevToolsAgentImpl::resumeStartup()
m_client->resumeStartup();
}
+void WebDevToolsAgentImpl::profilingStarted()
+{
+ if (m_overlay)
+ m_overlay->suspend();
+}
+
+void WebDevToolsAgentImpl::profilingStopped()
+{
+ if (m_overlay)
+ m_overlay->resume();
+}
+
void WebDevToolsAgentImpl::pageLayoutInvalidated(bool resized)
{
if (m_overlay)
« no previous file with comments | « third_party/WebKit/Source/web/WebDevToolsAgentImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698