Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Side by Side Diff: third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp

Issue 1933573002: [DevTools] Remove last bits of logic from v8 agent wrappers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1913283003
Patch Set: rebased, fixed uninitialized variable Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/inspector/ThreadDebugger.h" 5 #include "core/inspector/ThreadDebugger.h"
6 6
7 #include "bindings/core/v8/ScriptCallStack.h" 7 #include "bindings/core/v8/ScriptCallStack.h"
8 #include "bindings/core/v8/ScriptValue.h" 8 #include "bindings/core/v8/ScriptValue.h"
9 #include "bindings/core/v8/V8Binding.h" 9 #include "bindings/core/v8/V8Binding.h"
10 #include "bindings/core/v8/V8DOMException.h" 10 #include "bindings/core/v8/V8DOMException.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 data->threadDebugger()->debugger()->idleStarted(); 54 data->threadDebugger()->debugger()->idleStarted();
55 } 55 }
56 56
57 void ThreadDebugger::idleFinished(v8::Isolate* isolate) 57 void ThreadDebugger::idleFinished(v8::Isolate* isolate)
58 { 58 {
59 V8PerIsolateData* data = V8PerIsolateData::from(isolate); 59 V8PerIsolateData* data = V8PerIsolateData::from(isolate);
60 if (data && data->threadDebugger()) 60 if (data && data->threadDebugger())
61 data->threadDebugger()->debugger()->idleFinished(); 61 data->threadDebugger()->debugger()->idleFinished();
62 } 62 }
63 63
64 void ThreadDebugger::beginUserGesture()
65 {
66 m_userGestureIndicator = adoptPtr(new UserGestureIndicator(DefinitelyProcess ingNewUserGesture));
67 }
68
69 void ThreadDebugger::endUserGesture()
70 {
71 m_userGestureIndicator.clear();
72 }
73
64 void ThreadDebugger::eventListeners(v8::Local<v8::Value> value, V8EventListenerI nfoList& result) 74 void ThreadDebugger::eventListeners(v8::Local<v8::Value> value, V8EventListenerI nfoList& result)
65 { 75 {
66 InspectorDOMDebuggerAgent::eventListenersInfoForTarget(m_isolate, value, res ult); 76 InspectorDOMDebuggerAgent::eventListenersInfoForTarget(m_isolate, value, res ult);
67 } 77 }
68 78
69 String16 ThreadDebugger::valueSubtype(v8::Local<v8::Value> value) 79 String16 ThreadDebugger::valueSubtype(v8::Local<v8::Value> value)
70 { 80 {
71 if (V8Node::hasInstance(value, m_isolate)) 81 if (V8Node::hasInstance(value, m_isolate))
72 return "node"; 82 return "node";
73 if (V8NodeList::hasInstance(value, m_isolate) 83 if (V8NodeList::hasInstance(value, m_isolate)
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 m_timers.remove(id); 177 m_timers.remove(id);
168 } 178 }
169 179
170 void ThreadDebugger::onTimer(Timer<ThreadDebugger>* timer) 180 void ThreadDebugger::onTimer(Timer<ThreadDebugger>* timer)
171 { 181 {
172 ASSERT(m_timerCallbacks.contains(timer)); 182 ASSERT(m_timerCallbacks.contains(timer));
173 (*m_timerCallbacks.get(timer))(); 183 (*m_timerCallbacks.get(timer))();
174 } 184 }
175 185
176 } // namespace blink 186 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698