third_party/WebKit/Source/core/inspector/PageRuntimeAgent.h - Issue 1933573002: [DevTools] Remove last bits of logic from v8 agent wrappers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/PageRuntimeAgent.h

Issue 1933573002: [DevTools] Remove last bits of logic from v8 agent wrappers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1913283003

Patch Set: rebased, fixed uninitialized variable Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/PageRuntimeAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/PageRuntimeAgent.h b/third_party/WebKit/Source/core/inspector/PageRuntimeAgent.h

index 17b55273a3f7d9a2ef3bd749dd38c4a5a3473142..b06c6c2032591094e2e322d7e5b29934f4b1ee05 100644

--- a/third_party/WebKit/Source/core/inspector/PageRuntimeAgent.h

+++ b/third_party/WebKit/Source/core/inspector/PageRuntimeAgent.h

@@ -42,9 +42,9 @@ class InspectedFrames;

class CORE_EXPORT PageRuntimeAgent final : public InspectorRuntimeAgent {

public:

- static PageRuntimeAgent* create(InspectorRuntimeAgent::Client* client, V8RuntimeAgent* agent, InspectedFrames* inspectedFrames)

+ static PageRuntimeAgent* create(V8RuntimeAgent* agent, InspectedFrames* inspectedFrames)

{

- return new PageRuntimeAgent(client, agent, inspectedFrames);

+ return new PageRuntimeAgent(agent, inspectedFrames);

}

~PageRuntimeAgent() override;

DECLARE_VIRTUAL_TRACE();

@@ -52,7 +52,7 @@ public:

void disable(ErrorString*) override;

private:

- PageRuntimeAgent(Client*, V8RuntimeAgent*, InspectedFrames*);

+ PageRuntimeAgent(V8RuntimeAgent*, InspectedFrames*);

Member<InspectedFrames> m_inspectedFrames;

};