Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp

Issue 1933573002: [DevTools] Remove last bits of logic from v8 agent wrappers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1913283003
Patch Set: rebased, fixed uninitialized variable Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp
index e3bd1a13555094ddc9208b5b15484d3a880466dc..9da590350b09e42b48a43705883f2432682db586 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp
@@ -39,14 +39,8 @@ namespace ProfilerAgentState {
static const char profilerEnabled[] = "profilerEnabled";
}
-InspectorProfilerAgent* InspectorProfilerAgent::create(V8ProfilerAgent* agent, Client* client)
-{
- return new InspectorProfilerAgent(agent, client);
-}
-
-InspectorProfilerAgent::InspectorProfilerAgent(V8ProfilerAgent* agent, Client* client)
+InspectorProfilerAgent::InspectorProfilerAgent(V8ProfilerAgent* agent)
: InspectorBaseAgent<InspectorProfilerAgent, protocol::Frontend::Profiler>("Profiler")
- , m_client(client)
, m_v8ProfilerAgent(agent)
{
}
@@ -98,14 +92,10 @@ void InspectorProfilerAgent::setSamplingInterval(ErrorString* error, int interva
void InspectorProfilerAgent::start(ErrorString* error)
{
m_v8ProfilerAgent->start(error);
- if (m_client && error->isEmpty())
- m_client->profilingStarted();
}
void InspectorProfilerAgent::stop(ErrorString* errorString, OwnPtr<protocol::Profiler::CPUProfile>* profile)
{
- if (m_client)
- m_client->profilingStopped();
m_v8ProfilerAgent->stop(errorString, profile);
}

Powered by Google App Engine
This is Rietveld 408576698