Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1936593002: [DevTools] Remove state from v8 agent wrappers, remove unnecessary classes. (Closed)

Created:
4 years, 7 months ago by dgozman
Modified:
4 years, 7 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove-everything-from-agents
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove state from v8 agent wrappers, remove unnecessary classes. BUG=580337 Committed: https://crrev.com/203a4e3748254e287e11873c774d9d02d8d13c3e Cr-Commit-Position: refs/heads/master@{#392791}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -604 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp View 3 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.cpp View 3 chunks +0 lines, -19 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/PageDebuggerAgent.h View 1 chunk +0 lines, -68 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp View 1 chunk +0 lines, -86 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/PageRuntimeAgent.h View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp View 1 chunk +0 lines, -76 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/WorkerDebuggerAgent.h View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/WorkerDebuggerAgent.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/WorkerRuntimeAgent.h View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/WorkerRuntimeAgent.cpp View 1 chunk +0 lines, -62 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 4 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp View 4 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp View 1 4 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 4 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1933573002 Patch 40001

Dependent Patchsets:

Issue 1967933002 Patch 1

Messages

Total messages: 9 (4 generated)
dgozman
Take a look please.
4 years, 7 months ago (2016-04-29 17:19:11 UTC) #2
caseq
lgtm
4 years, 7 months ago (2016-04-29 17:42:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936593002/20001
4 years, 7 months ago (2016-05-10 23:00:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-11 00:45:09 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 00:46:48 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/203a4e3748254e287e11873c774d9d02d8d13c3e
Cr-Commit-Position: refs/heads/master@{#392791}

Powered by Google App Engine
This is Rietveld 408576698