Always set symbol visibility when compiling with GCC / Clang.

Always set symbol visibility when compiling with GCC / Clang.

By default, GN includes //build/config/gcc:symbol_visibility_hidden
into every target. Some targets remove this config. At least some of
the compiler options require the visibility to be set explicitly,
and they issue a compiler error otherwise.

This change introduced a new GN config, //build/config/gcc:symbol_visibility_default,
and the targets which remove //build/config/gcc:symbol_visibility_hidden,
must add this one.

BUG=607370
Committed: https://crrev.com/02e28619639d5cf2db5ac346d3328ec0762d6e14
Cr-Commit-Position: refs/heads/master@{#390784}

[krasin, 2016-04-28 01:20:49]

krasin@google.com changed reviewers:
+ brettw@chromium.org

[krasin, 2016-04-28 18:42:32]

Friendly ping!

[krasin, 2016-04-28 22:45:39]

Ping2

[krasin, 2016-04-28 23:02:21]

krasin@google.com changed reviewers:
+ dpranke@google.com

[krasin, 2016-04-28 23:02:22]

Hi Dirk,

can you please take a look at these GN config changes?

Thank you in advance,
krasin

[krasin, 2016-04-28 23:02:58]

This is to fix 'CFI Linux ToT' buildbot:
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT/builds/2022

[Dirk Pranke, 2016-04-28 23:08:52]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-04-28 23:08:53]

lgtm, but I'm not an expert here, so I'm kinda taking your word for it.

[krasin, 2016-04-28 23:32:06]

krasin@google.com changed reviewers:
+ pcc@chromium.org

[krasin, 2016-04-28 23:32:06]

Hi Peter,

can you please review this change proposed by you in
https://bugs.chromium.org/p/chromium/issues/detail?id=607370#c8

[pcc1, 2016-04-28 23:39:02]

lgtm

[krasin, 2016-04-28 23:39:47]

Thank you, Dirk and Peter!

I will try to submit.

[krasin, 2016-04-28 23:39:50]

The CQ bit was checked by krasin@google.com

[commit-bot: I haz the power, 2016-04-28 23:40:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1930773002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1930773002/20001

[commit-bot: I haz the power, 2016-04-28 23:50:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 23:50:16]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dirk Pranke, 2016-04-28 23:55:37]

You probably still need brettw@'s approval to cover the files in the other
subdirectories (or other individual owners).

[krasin, 2016-04-29 00:02:54]

Brett,

may I have your LGTM please? I hope the approvals from Dirk and Peter make it
easier to accept this mechanical change.

Dirk -- thank you.

[krasin, 2016-04-29 00:22:16]

The CQ bit was checked by krasin@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 00:22:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1930773002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1930773002/20001

[commit-bot: I haz the power, 2016-04-29 01:22:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 01:22:07]

Dry run: This issue passed the CQ dry run.

[krasin, 2016-04-29 18:48:06]

Brett, very last ping.

I am leaning towards splitting this CL into 6 small CLs and sending them to the
corresponding OWNERS.

[Dirk Pranke, 2016-04-29 19:01:39]

On 2016/04/29 18:48:06, krasin wrote:
> Brett, very last ping.
> 
> I am leaning towards splitting this CL into 6 small CLs and sending them to
the
> corresponding OWNERS.

I suggest you get thakis@ to review it and TBR brett or jam.

[krasin, 2016-04-29 19:50:03]

Hi Nico,

can you please take a look at the CL? (suggested by Dirk)

Dirk - thank you for the suggestion.

[brettw, 2016-04-29 20:15:43]

lgtm

[krasin, 2016-04-29 20:21:11]

The CQ bit was checked by krasin@google.com

[krasin, 2016-04-29 20:21:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, pcc@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1930773002/#ps40001
(title: "sync")

[krasin, 2016-04-29 20:21:27]

Thank you, Brett!

[commit-bot: I haz the power, 2016-04-29 20:21:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1930773002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1930773002/40001

[commit-bot: I haz the power, 2016-04-29 22:28:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-30 17:29:38]

Patchset 3 (id:??) landed as
https://crrev.com/02e28619639d5cf2db5ac346d3328ec0762d6e14
Cr-Commit-Position: refs/heads/master@{#390784}

[commit-bot: I haz the power, 2016-04-30 18:03:07]

Description was changed from

==========
Always set symbol visibility when compiling with GCC / Clang.

By default, GN includes //build/config/gcc:symbol_visibility_hidden
into every target. Some targets remove this config. At least some of
the compiler options require the visibility to be set explicitly,
and they issue a compiler error otherwise.

This change introduced a new GN config,
//build/config/gcc:symbol_visibility_default,
and the targets which remove //build/config/gcc:symbol_visibility_hidden,
must add this one.

BUG=607370
==========

to

==========
Always set symbol visibility when compiling with GCC / Clang.

By default, GN includes //build/config/gcc:symbol_visibility_hidden
into every target. Some targets remove this config. At least some of
the compiler options require the visibility to be set explicitly,
and they issue a compiler error otherwise.

This change introduced a new GN config,
//build/config/gcc:symbol_visibility_default,
and the targets which remove //build/config/gcc:symbol_visibility_hidden,
must add this one.

BUG=607370

Committed: https://crrev.com/02e28619639d5cf2db5ac346d3328ec0762d6e14
Cr-Commit-Position: refs/heads/master@{#390784}
==========