Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/google_toolbox_for_mac/BUILD.gn

Issue 1930773002: Always set symbol visibility when compiling with GCC / Clang. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ppapi/native_client/src/untrusted/irt_stub/BUILD.gn ('k') | third_party/harfbuzz-ng/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 config("google_toolbox_for_mac_config") { 5 config("google_toolbox_for_mac_config") {
6 include_dirs = [ 6 include_dirs = [
7 ".", 7 ".",
8 "src", 8 "src",
9 "src/AppKit", 9 "src/AppKit",
10 "src/DebugUtils", 10 "src/DebugUtils",
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 } 195 }
196 196
197 if (is_component_build) { 197 if (is_component_build) {
198 # GTM is third-party code, so we don't want to add _EXPORT 198 # GTM is third-party code, so we don't want to add _EXPORT
199 # annotations to it, so build it without -fvisibility=hidden 199 # annotations to it, so build it without -fvisibility=hidden
200 # (else the interface class symbols will be hidden in a 64bit 200 # (else the interface class symbols will be hidden in a 64bit
201 # build). Only do this in a component build, so that the shipping 201 # build). Only do this in a component build, so that the shipping
202 # chrome binary doesn't end up with unnecessarily exported 202 # chrome binary doesn't end up with unnecessarily exported
203 # symbols. 203 # symbols.
204 configs -= [ "//build/config/gcc:symbol_visibility_hidden" ] 204 configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
205 configs += [ "//build/config/gcc:symbol_visibility_default" ]
205 } 206 }
206 } 207 }
OLDNEW
« no previous file with comments | « ppapi/native_client/src/untrusted/irt_stub/BUILD.gn ('k') | third_party/harfbuzz-ng/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698