Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: ppapi/native_client/src/untrusted/irt_stub/BUILD.gn

Issue 1930773002: Always set symbol visibility when compiling with GCC / Clang. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ppapi/BUILD.gn ('k') | third_party/google_toolbox_for_mac/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 assert(is_nacl, 5 assert(is_nacl,
6 "These targets must only be built using the untrusted NaCl toolchains.") 6 "These targets must only be built using the untrusted NaCl toolchains.")
7 7
8 static_library("ppapi_stub_lib") { 8 static_library("ppapi_stub_lib") {
9 output_name = "ppapi_stub" 9 output_name = "ppapi_stub"
10 10
11 # This library is distributed as a part of the SDK and as such has to 11 # This library is distributed as a part of the SDK and as such has to
12 # be a static library rather than a source set. 12 # be a static library rather than a source set.
13 sources = [ 13 sources = [
14 "plugin_main_irt.c", 14 "plugin_main_irt.c",
15 "ppapi_plugin_main.c", 15 "ppapi_plugin_main.c",
16 "ppapi_plugin_start.c", 16 "ppapi_plugin_start.c",
17 "thread_creator.c", 17 "thread_creator.c",
18 ] 18 ]
19 configs -= [ "//build/config/gcc:symbol_visibility_hidden" ] 19 configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
20 configs += [ "//build/config/gcc:symbol_visibility_default" ]
20 cflags = [ "-fPIC" ] 21 cflags = [ "-fPIC" ]
21 deps = [ 22 deps = [
22 "//build/config/nacl:nacl_base", 23 "//build/config/nacl:nacl_base",
23 ] 24 ]
24 } 25 }
OLDNEW
« no previous file with comments | « ppapi/BUILD.gn ('k') | third_party/google_toolbox_for_mac/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698