Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: third_party/harfbuzz-ng/BUILD.gn

Issue 1930773002: Always set symbol visibility when compiling with GCC / Clang. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/google_toolbox_for_mac/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 import("//build/config/linux/pkg_config.gni") 6 import("//build/config/linux/pkg_config.gni")
7 import("//build/config/ui.gni") 7 import("//build/config/ui.gni")
8 8
9 declare_args() { 9 declare_args() {
10 # Blink uses a cutting-edge version of Harfbuzz; most Linux distros do not 10 # Blink uses a cutting-edge version of Harfbuzz; most Linux distros do not
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 } 183 }
184 184
185 # When without -fvisibility=hidden for pango to use the harfbuzz 185 # When without -fvisibility=hidden for pango to use the harfbuzz
186 # in the tree, all symbols pango needs must be included, or 186 # in the tree, all symbols pango needs must be included, or
187 # pango uses mixed versions of harfbuzz and leads to crash. 187 # pango uses mixed versions of harfbuzz and leads to crash.
188 # See crbug.com/462689. 188 # See crbug.com/462689.
189 if (is_linux && use_pango && !is_chromeos && !is_official_build && 189 if (is_linux && use_pango && !is_chromeos && !is_official_build &&
190 current_cpu != "arm" && current_cpu != "mipsel") { 190 current_cpu != "arm" && current_cpu != "mipsel") {
191 deps += [ "//build/linux:freetype2" ] 191 deps += [ "//build/linux:freetype2" ]
192 configs -= [ "//build/config/gcc:symbol_visibility_hidden" ] 192 configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
193 configs += [ "//build/config/gcc:symbol_visibility_default" ]
193 configs += [ "//build/config/linux:glib" ] 194 configs += [ "//build/config/linux:glib" ]
194 sources += [ 195 sources += [
195 "src/hb-ft.cc", 196 "src/hb-ft.cc",
196 "src/hb-ft.h", 197 "src/hb-ft.h",
197 "src/hb-glib.cc", 198 "src/hb-glib.cc",
198 "src/hb-glib.h", 199 "src/hb-glib.h",
199 ] 200 ]
200 } 201 }
201 } 202 }
202 } 203 }
OLDNEW
« no previous file with comments | « third_party/google_toolbox_for_mac/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698