third_party/google_toolbox_for_mac/BUILD.gn - Issue 1930773002: Always set symbol visibility when compiling with GCC / Clang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/google_toolbox_for_mac/BUILD.gn

Issue 1930773002: Always set symbol visibility when compiling with GCC / Clang. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sync Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/google_toolbox_for_mac/BUILD.gn

diff --git a/third_party/google_toolbox_for_mac/BUILD.gn b/third_party/google_toolbox_for_mac/BUILD.gn

index 49fa91ce2c710f79c5bc7ffd5804e3fe59577cd8..b0461d0acbcf96a2949c2177ef35bcb2016c2b89 100644

--- a/third_party/google_toolbox_for_mac/BUILD.gn

+++ b/third_party/google_toolbox_for_mac/BUILD.gn

@@ -202,5 +202,6 @@ component("google_toolbox_for_mac") {

# chrome binary doesn't end up with unnecessarily exported

# symbols.

configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]

+ configs += [ "//build/config/gcc:symbol_visibility_default" ]

}

« no previous file with comments | « ppapi/native_client/src/untrusted/irt_stub/BUILD.gn ('k') | third_party/harfbuzz-ng/BUILD.gn » ('j') | no next file with comments »